Fix PODVector shrink_to_fit() with nonzero size #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

WeiqunZhang merged 1 commit into AMReX-Codes:development from AlexanderSinn:Fix_PODVector_shrink_to_fit_with_nonzero_size

Nov 3, 2025

Member

AlexanderSinn commented Nov 3, 2025

Summary

While working on #4735 I noticed that in shrink_to_fit the newly allocated data pointer was not saved in the PODVector.

Additional background

Checklist

The proposed changes:

fix a bug or incorrect behavior in AMReX
add new capabilities to AMReX
changes answers in the test suite to more than roundoff level
are likely to significantly affect the results of downstream AMReX users
include documentation in the code and/or rst files, if appropriate


          Fix PODVector shrink_to_fit with nonzero size

e78b272

AlexanderSinn requested a review from WeiqunZhang

November 3, 2025 16:58

WeiqunZhang approved these changes

View reviewed changes

WeiqunZhang merged commit 8031a6e into AMReX-Codes:development

73 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet