Catch Sphinx build errors in CI #4751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
atmyers
changed the title
atmyers
changed the title
WeiqunZhang
reviewed
Nov 3, 2025
build_docs.sh
Outdated
| make SPHINXOPTS='-v -W --keep-going' PYTHON="python3" latexpdf | ||
| mv build/latex/amrex.pdf source/ | ||
| make PYTHON="python3" html &> make_source_html.out | ||
| make SPHINXOPTS='-v -W --keep-going' PYTHON="python3" html &> make_source_html.out |
Member
There was a problem hiding this comment.
I think we should remove &> make_source_html.out so that we can actually see the output and error.
Member
There was a problem hiding this comment.
We also need to build html first to treat warnings as errors, if we ignore the warnings from latexpdf. Or we do make clean before make html.
Member
There was a problem hiding this comment.
make html was reusing the results of make latexpdf. That was why it did not break.
Member
Author
There was a problem hiding this comment.
The current code breaks. Now let me fix the table again.
Member
|
There is |
WeiqunZhang
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional background
Checklist
The proposed changes: