Skip to content

RNG on GPU: Assertion it's not in OMP parallel region #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

RNG on GPU: Assertion it's not in OMP parallel region #4799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions Src/Base/AMReX_RandomEngine.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

#include <AMReX_GpuQualifiers.H>
#include <AMReX_Extension.H>
#ifdef AMREX_USE_OMP
# include <AMReX_BLassert.H>
# include <omp.h>
#endif

#if defined(AMREX_USE_HIP)
#pragma clang diagnostic push
Expand Down Expand Up @@ -32,8 +36,13 @@ namespace amrex

extern sycl_rng_descr* rand_engine_descr;

AMREX_FORCE_INLINE
sycl_rng_descr* getRandEngineDescriptor () { return rand_engine_descr; }
inline
sycl_rng_descr* getRandEngineDescriptor () {
#ifdef AMREX_USE_OMP
AMREX_ALWAYS_ASSERT_WITH_MESSAGE(! omp_in_parallel(), "RNG on GPU is not OpenMP thread safe");
#endif
return rand_engine_descr;
}

struct RandomEngine {
sycl_rng_engine* engine;
Expand All @@ -52,8 +61,13 @@ namespace amrex

extern randState_t* gpu_rand_state;

AMREX_FORCE_INLINE
randState_t* getRandState () { return gpu_rand_state; }
inline
randState_t* getRandState () {
#ifdef AMREX_USE_OMP
AMREX_ALWAYS_ASSERT_WITH_MESSAGE(! omp_in_parallel(), "RNG on GPU is not OpenMP thread safe");
#endif
return gpu_rand_state;
}

struct RandomEngine {
randState_t* rand_state;
Expand Down
Loading