Skip to content

Conversation

@VaibhavSain
Copy link

@VaibhavSain VaibhavSain commented Nov 15, 2025


📌 Issue Overview

The GitHub button link in the landing page header is incorrect and does not redirect to the intended repository. This causes users to land on the wrong page or receive an error.

🔍 Steps to Reproduce

  1. Go to the landing page.
  2. Click on the GitHub button in the header section.
  3. Observe the redirection behavior.
  4. See the incorrect or broken link.

🎯 Expected Behavior

The GitHub button should correctly redirect users to the proper GitHub repository.

🚨 Actual Behavior

The button currently points to an incorrect/invalid link, leading users to the wrong page or showing an error.

📷 Screenshot

Screenshot_20251115_085756 [Screencast_20251115_090542.webm](https://github.com/user-attachments/assets/2cb6901c-4f6b-4e0d-816d-b03d877f3b19)

💡 Suggested Improvements

  • Update the GitHub button link to the correct repository URL.
  • Verify the change visually to ensure proper redirection.
  • Optionally add link validation in the future to prevent similar issues.

Summary by CodeRabbit

  • Bug Fixes
    • GitHub button now opens the GitHub page in a new tab when clicked.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2025

Walkthrough

The GitHub component adds an internal openLink function that calls window.open for the GitHub URL and wires it to the existing button's onClick, making the button interactive without changing the component's public signature.

Changes

Cohort / File(s) Summary
Button interactivity enhancement
LandingPage/src/components/github.tsx
Added internal openLink function to open the GitHub URL via window.open; attached openLink to the button's onClick handler to make the button clickable.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Button
  participant Component
  participant Browser

  User->>Button: click
  Button->>Component: onClick -> openLink()
  alt URL opens successfully
    Component->>Browser: window.open(githubUrl)
    Browser-->>User: new tab/window with GitHub
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Confirm the GitHub URL string is correct.
  • Verify window.open target (e.g., _blank) and consider noopener/noreferrer if needed.
  • Check for any linting/TypeScript warnings around window usage for SSR contexts.

Poem

🐰 I clicked my paw and gave a tap,
The button leapt — away! — a map,
A tiny window, open wide,
To GitHub's meadow, hops my stride. 🚪✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix Github Button Link' directly corresponds to the main change: adding functionality to make the GitHub button clickable and link to the correct GitHub repository. It clearly summarizes the primary fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c25877 and 12c6740.

📒 Files selected for processing (1)
  • LandingPage/src/components/github.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • LandingPage/src/components/github.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
LandingPage/src/components/github.tsx (1)

9-14: Consider using an anchor tag instead of button for external navigation.

While the current implementation works, using a <button> for external navigation is not semantically correct. An anchor (<a>) tag would provide better accessibility, allow native browser features (right-click context menu, keyboard shortcuts), and improve SEO.

Apply this diff to refactor to an anchor tag:

-      <button onClick={openLink} className="btn-github">
+      <a href="https://github.com/AOSSIE-Org/" target="_blank" rel="noopener noreferrer" className="btn-github">
        <svg width={16} height={16} viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
          <path d="M7.99992 1.33331C7.12444 1.33331 6.25753 1.50575 5.4487 1.84078C4.63986 2.17581 3.90493 2.66688 3.28587 3.28593C2.03563 4.53618 1.33325 6.23187 1.33325 7.99998C1.33325 10.9466 3.24659 13.4466 5.89325 14.3333C6.22659 14.3866 6.33325 14.18 6.33325 14C6.33325 13.8466 6.33325 13.4266 6.33325 12.8733C4.48659 13.2733 4.09325 11.98 4.09325 11.98C3.78659 11.2066 3.35325 11 3.35325 11C2.74659 10.5866 3.39992 10.6 3.39992 10.6C4.06659 10.6466 4.41992 11.2866 4.41992 11.2866C4.99992 12.3 5.97992 12 6.35992 11.84C6.41992 11.4066 6.59325 11.1133 6.77992 10.9466C5.29992 10.78 3.74659 10.2066 3.74659 7.66665C3.74659 6.92665 3.99992 6.33331 4.43325 5.85998C4.36659 5.69331 4.13325 4.99998 4.49992 4.09998C4.49992 4.09998 5.05992 3.91998 6.33325 4.77998C6.85992 4.63331 7.43325 4.55998 7.99992 4.55998C8.56659 4.55998 9.13992 4.63331 9.66659 4.77998C10.9399 3.91998 11.4999 4.09998 11.4999 4.09998C11.8666 4.99998 11.6333 5.69331 11.5666 5.85998C11.9999 6.33331 12.2533 6.92665 12.2533 7.66665C12.2533 10.2133 10.6933 10.7733 9.20659 10.94C9.44659 11.1466 9.66659 11.5533 9.66659 12.1733C9.66659 13.0666 9.66659 13.7866 9.66659 14C9.66659 14.18 9.77325 14.3933 10.1133 14.3333C12.7599 13.44 14.6666 10.9466 14.6666 7.99998C14.6666 7.1245 14.4941 6.25759 14.1591 5.44876C13.8241 4.63992 13.333 3.90499 12.714 3.28593C12.0949 2.66688 11.36 2.17581 10.5511 1.84078C9.7423 1.50575 8.8754 1.33331 7.99992 1.33331V1.33331Z" fill="currentcolor" />
        </svg>
        <span>Contribute on Github</span>
-      </button>
+      </a>

Then remove the openLink function (lines 4-6) as it would no longer be needed. You'll also need to update the CSS selector from .btn-github button styles to work with anchor tags (add text-decoration: none; and display: inline-flex; or display: flex;).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3be437 and 3c25877.

⛔ Files ignored due to path filters (1)
  • LandingPage/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • LandingPage/src/components/github.tsx (1 hunks)

@VaibhavSain VaibhavSain changed the title fit github button link Fix Github Button Link Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant