-
Notifications
You must be signed in to change notification settings - Fork 256
fix: The release of APK is fixed. #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Release v3.0.0
Signed-off-by: uju09 <[email protected]>
This reverts commit 0cd58c7.
Signed-off-by: uju09 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe Build and Deploy GitHub Actions workflow is fixed by adding disk space management, implementing proper cache cleanup, and updating artifact path handling to use an environment variable (APK_RELEASE_PATH) alongside a corrected MIME type for Android package releases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 Welcome @uju09!
We appreciate your contribution! 🚀 |
|
@M4dhav I request you to review. |
|
Please follow the specified PR template and don't overwrite it in the future |
|
Please test the workflow locally and share a video |
M4dhav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for test video
|
@M4dhav Sorry for PR body. I forgot. |
|
@M4dhav I don't have secrets with me. Testing it locally is not possible. |
|
You can setup your own secrets locally on your fork |
|
Where to get secrets. I am in Web dev. I don't know much about App dev and its release. |
|
@M4dhav Can you test it on test branch. I request you. |
All of the secrets are self explanatory, and as this is for GitHub Release, you don't need credentials for an App Console account. You will be able to easily find where to generate which secret. |
I'm sorry, I do not have the time right now to do so |
|
@M4dhav Ok give me some time. I will try and share a video. |
|
@M4dhav I request you to test the workflow. |
Signed-off-by: uju09 <[email protected]>
Signed-off-by: uju09 <[email protected]>
Signed-off-by: uju09 <[email protected]>
|
@coderabbitai Review. |
|
@uju09: I'll review the changes in this PR for you. ✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build_and_deploy.yml (1)
27-42: Approve disk housekeeping; consider pinning the action version.The disk space cleanup steps are well-placed and should resolve common CI/CD runner failures. The disk usage visibility aids debugging.
However, the
free-disk-space@mainaction is unpinned to a specific version. This can cause reproducibility issues if the action changes behavior in the future.Consider pinning to a specific version tag:
- uses: jlumbroso/free-disk-space@main + uses: jlumbroso/[email protected]You can check the latest stable version at https://github.com/jlumbroso/free-disk-space/releases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build_and_deploy.yml(4 hunks)
🔇 Additional comments (2)
.github/workflows/build_and_deploy.yml (2)
58-65: Good placement and scope of build cleanup step.The cleanup step is well-positioned after Flutter setup but before artifact builds, and comprehensively removes Flutter, Gradle, and cache artifacts. This should eliminate stale build cache issues.
106-119: Verify APK artifact path resolution and MIME type update.The
APK_RELEASE_PATHenvironment variable and MIME type update appear correct:
- Path
apk-release/app-release.apkshould align with the upload structure (artifact name + filename)- MIME type
application/vnd.android.package-archiveis the standard type for Android packagesHowever, verification requires access to the workflow file's upload configuration (lines 94-98) to confirm that the artifact download on lines 110–112 places files in the expected
apk-release/directory so the path resolves correctly at release time. Specifically, verify that the upload step usesname: apk-releaseand that the fileapp-release.apkwill be in the correct nested directory after download.
| dotnet: true | ||
| haskell: true | ||
| large-packages: true | ||
| docker-images: true | ||
| swap-storage: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even have any of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no idea what we have, so I thought to give it a try, and also it is future proof to clear the disk storage.
| artifactContentType: apk | ||
| artifactContentType: application/vnd.android.package-archive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came by mistake, in cursor there was an syntax error and I pressed tab for autocompletion, it may be incurred at that time.
Signed-off-by: uju09 <[email protected]>
|
Failed with a different error: un android-actions/setup-android@v3 I believe this is becuase we are deleting android |
|
@M4dhav I will fix it. |
Signed-off-by: uju09 <[email protected]>
|
@M4dhav I removed that cleaning job, I think it is disturbing the flow, however the job of cleaning cache and previous build is still there. |
M4dhav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the same error as last time. Add back the previous cleaning job but remove some of the parts like android set to false
Space error |
Signed-off-by: uju09 <[email protected]>
|
@M4dhav Changes have been made. |
M4dhav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@M4dhav I think the name of file was wrong, I will fix it. |
Signed-off-by: uju09 <[email protected]>
|
@M4dhav There was a typo, Now it will succeed. |
M4dhav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: uju09 <[email protected]>
|
@M4dhav I am sorry for irritating. Due to consistent errors, I took suggestions from AI and my seniors and updated the release action version to latest. It is my fault, I would have checked earlier whether it is right or not. I apologize for that. Don't know why but this workflow is taking too much time, though it should not take, but it is giving trouble and all types of errors, so I was trying to analyse it from every angle. |
|
@M4dhav Now I think everything is fine... and it should do its job. |
It is alright. The workflow is working fine now. Could you make a few more modifications please? The Build Tag and Release Notes should be fetched from the Changelog |
|
@M4dhav Hey, I think we should write our CHANGELOG.md in order of latest version. Currently the latest version is at last, can we modify it , so it becomes easy for contributors and for job too for parsing. |
If that is the case, then sure, we can have it top to bottom. Please feel free to raise a PR for the same |
|
@M4dhav Ok then I will create an issue. Currently I am busy with my internship, I am will try to resolve all assigned issue as soon as possible. |




Description
This PR fixes the broken release job of Build and Deploy workflow.
Fixes #539
Type of change
Checklist:
Maintainer Checklist
github_workflowSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.