add task manager #16570
Open
add task manager #16570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkpark
requested review from
AUTOMATIC1111,
catboxanon and
w-e-w
as code owners
based on https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/modules_forge/main_thread.py * classified * this way, gc.collect() will work as intended.
Parvezkhan0
reviewed
May 29, 2025
Comment on lines
+73
to
+80
| while True: | ||
| time.sleep(0.01) | ||
| if current_id in self.finished_tasks: | ||
| finished = self.finished_tasks.pop(current_id) | ||
| if finished.exception is not None: | ||
| raise finished.exception | ||
|
|
||
| return finished.result |
There was a problem hiding this comment.
Wrap modifications of pending_tasks and access to finished_tasks in self.lock.
| def __init__(self): | ||
| self.lock = threading.Lock() | ||
|
|
||
| def work(self, task): |
There was a problem hiding this comment.
To avoid memory bloat, optionally limit or expire old entries in finished_tasks
Comment on lines
+46
to
+54
| def main_loop(self): | ||
| self.running = True | ||
| while self.running: | ||
| time.sleep(0.01) | ||
| if len(self.pending_tasks) > 0: | ||
| with self.lock: | ||
| task = self.pending_tasks.pop(0) | ||
|
|
||
| self.work(task) |
There was a problem hiding this comment.
Optionally increase sleep time when no tasks are pending, or use threading.Condition() for efficiency:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/modules_forge/main_thread.py
original author's comment in the source code:
and it's commit:
lllyasviel/stable-diffusion-webui-forge@f06ba8e
from commit message:
all tests have been passed but coverage not work)extracted from PR #16484