-
Notifications
You must be signed in to change notification settings - Fork 408
Enhance render test output #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add in option to filter out rows based on minimum RMS value. - Add in option JSON, and Markdown options - Cleaned up HTML output.
|
This looks really compelling, @kwokcb, and I'm looking forward to trying this out in the render test suite! |
Was pruning when no error tolerance set.
- Will pack by default (prevous behaviour) - -w <=0 will make it responsive. - Revert -e arg help.
|
I like the added flexibility in the new HTML generation, though when I run the render tests through our usual PDF-generation process, the rendered images seem to be smaller on the page, with an extra white border around them: MaterialXRenderTests_11_22_2025_GitHub.pdf Do you think it would be possible to adjust the default HTML generation to restore the original size of the images on the page, without the additional white border? |
Preserve the image size, border and spacing from original version.
…0 size if use original 512. (122 to 10 MB). and with 256 width to 3MB. This makes easier to store comparisons images in PDF. The idea is to use base64 encoding into JPG and embed it into the html.This also means less disk read / writes for diff image generation. Uses OpenCV + numpy for fast resize. PIL and OpenImage are much slower for this encoding case. JSON storage is about 4mb from 160K when embedding encoded images. Replaced diff with OpenCV + numpy instead of PIL to avoid extra data copies.
|
@jstone-lucasfilm , @ld-kerley : This is about as far as I'm going to take this change for now. (Jonathan, the formatting is as close to the original static tables as possible for html.). |
|
Example run with small change to add hash compares. |
Changes
Output
JSON, Markdown, HTML output
HTML results responsive (fills) vs packed.
Embedding Example
Markdown embedding. This can be stored on any github repo without the original files.
PDF file with reduced images. Straight HTML->PDF save.
Test Results.pdf