Enable CI Rendering on Mac #2673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwokcb
requested review from
jstone-lucasfilm,
ld-kerley and
lfl-eholthouser
and removed request for
lfl-eholthouser
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks really promising, @kwokcb, and I had just one initial recommendation for improving clarity.
.github/workflows/main.yml
Outdated
| python python/Scripts/baketextures.py resources/Materials/Examples/StandardSurface/standard_surface_brass_tiled.mtlx build/render/brass_average_baked.mtlx --average | ||
| python python/Scripts/translateshader.py resources/Materials/Examples/StandardSurface/standard_surface_carpaint.mtlx build/render/usd_preview_surface_carpaint.mtlx UsdPreviewSurface --hdr | ||
| - name: Render Application Tests |
Member
There was a problem hiding this comment.
Since you've split the steps for the Viewer and Graph Editor, I'd say we can go further and call this step "Viewer Tests", and call the next step "Graph Editor Tests (Linux)".
jstone-lucasfilm
approved these changes
Nov 14, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Great work, thanks @kwokcb! This should make a significant difference in validating MacOS rendering changes going forward.
jstone-lucasfilm
merged commit fbb6100
into
AcademySoftwareFoundation:main
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Results:
Notes: