-
Notifications
You must be signed in to change notification settings - Fork 95
ACNA-4183: Add Clarification Around Path Resolution #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/pages/guides/app_builder_guides/architecture_overview/app-hooks.md
Outdated
Show resolved
Hide resolved
danidelcar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a minor comment
pru55e11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple suggestions for clarity
src/pages/guides/app_builder_guides/architecture_overview/app-hooks.md
Outdated
Show resolved
Hide resolved
src/pages/guides/app_builder_guides/configuration/configuration.md
Outdated
Show resolved
Hide resolved
purplecabbage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pr!
We need to clarify that hooks are not themselves $include'd otherwise I think we risk making this less clear.
Description
Clarify path resolution between
hooksand other components inapp.config.yamlwhen using$include.Ticket
ACNA-4183