Skip to content

Conversation

@iivvaannxx
Copy link
Collaborator

Description

Clarify path resolution between hooks and other components in app.config.yaml when using $include.

Ticket

ACNA-4183

@iivvaannxx iivvaannxx requested review from pru55e11 and shazron and removed request for shazron November 11, 2025 09:43
Copy link

@danidelcar danidelcar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a minor comment

Copy link
Collaborator

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple suggestions for clarity

Copy link
Contributor

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pr!
We need to clarify that hooks are not themselves $include'd otherwise I think we risk making this less clear.

@pru55e11 pru55e11 merged commit 5a425c4 into main Nov 20, 2025
2 checks passed
@pru55e11 pru55e11 deleted the ACNA-4183-clarify-hooks-paths branch November 20, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants