Skip to content

Conversation

@xordspar0
Copy link
Contributor

Backported from AppImage/AppImageKit#1247

@xordspar0
Copy link
Contributor Author

xordspar0 commented Feb 25, 2023

The build fails on Alpine 3.17+ because zstd-static no longer exists; it was merged into zstd-dev. It's trivial to fix this and make both the chroot and qemu builds use Alpine 3.17, but maybe it's better to stick to an older release of Alpine in case musl built on a newer kernel starts depending on new kernel features?

@xordspar0
Copy link
Contributor Author

xordspar0 commented Feb 25, 2023

maybe it's better to stick to an older release of Alpine

Hm, run-on-arch-action, used for the qemu build, only supports alpine_latest. And now that I've looked into how that action works, using a different distro version doesn't change which kernel you get anyway, since it's just a Docker container and qemu running in user mode. In that case I will update the build to work with Alpine 3.17 unless I can find a different way to cross compile with qemu.

@probonopd
Copy link
Member

probonopd commented Feb 26, 2023

@TheAssassin lgtm; wdyt?

probonopd added a commit that referenced this pull request Mar 4, 2023
@xordspar0
Copy link
Contributor Author

@probonopd, Does TheAssassin know to check for pull requests on this repo? It looks like he hasn't contributed to or reviewed PRs on type2-runtime before.

@probonopd
Copy link
Member

I'd assume he is just busy with other things; in general he knows this repository :-)

probonopd added a commit that referenced this pull request Apr 16, 2023
* Use libfuse3

* 3.17.2

* zstd-static was folded into zstd-dev

#5 (comment)
@probonopd probonopd requested a review from TheAssassin July 1, 2023 19:07
@probonopd
Copy link
Member

Friendly ping @TheAssassin - maybe you can have a look at this when you have some time (says the guy who hasn't enough time, most of the time).

msojocs pushed a commit to msojocs/type2-runtime-loongarch that referenced this pull request May 19, 2024
@probonopd
Copy link
Member

Ready for merging @TheAssassin?

@github-actions
Copy link

github-actions bot commented Nov 3, 2024

Build for testing:
artifacts
Use at your own risk.

@TheAssassin TheAssassin enabled auto-merge (squash) December 8, 2024 15:28
@TheAssassin TheAssassin merged commit 0d520df into AppImage:main Dec 8, 2024
9 checks passed
@xordspar0 xordspar0 deleted the home-and-config-for-extracted branch December 9, 2024 16:17
@xordspar0
Copy link
Contributor Author

Yay, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants