Skip to content

Conversation

@probonopd
Copy link
Member

Closes #77; thanks @Randrianasulu

@github-actions
Copy link

Build for testing:
artifacts
Use at your own risk.

@TheAssassin
Copy link
Member

Looks good to me. Would you mind fixing the (unrelated) build failure by changing a 2 for a 4 in the artifacts action?

@github-actions
Copy link

Build for testing:
artifacts
Use at your own risk.

@probonopd probonopd enabled auto-merge (squash) October 21, 2024 16:46
@probonopd
Copy link
Member Author

With v4 it does not work. Hence downgrading again.

Traceback (most recent call last):
  File "<frozen runpy>", line 1[9](https://github.com/AppImage/type2-runtime/actions/runs/11427873502/job/31792563805?pr=78#step:4:10)8, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/tmp/appimage_extracted_556096427a8a96a78afb7e0fd53896f2/usr/conda/lib/python3.[11](https://github.com/AppImage/type2-runtime/actions/runs/11427873502/job/31792563805?pr=78#step:4:12)/site-packages/pyuploadtool/__main__.py", line 31, in <module>
    raise FileNotFoundError(artifact)
FileNotFoundError: artifacts/*

@github-actions
Copy link

Build for testing:
artifacts
Use at your own risk.

@probonopd
Copy link
Member Author

Now we get

Error: This request has been automatically failed because it uses a deprecated version of actions/download-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

I don't know how to fix this, or how to merge this PR. The old v2 used to work, v4 throws an error, and downgrading this PR doesn't seem to be possible. Any idea @TheAssassin?

@Randrianasulu
Copy link

Now we get

Error: This request has been automatically failed because it uses a deprecated version of actions/download-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

I don't know how to fix this, or how to merge this PR. The old v2 used to work, v4 throws an error, and downgrading this PR doesn't seem to be possible. Any idea @TheAssassin?


any relevant info there?

https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes

it says v4 fails to download artefacts created by upload artefacts v3 and below ?

@TheAssassin
Copy link
Member

We've had similar issues in some other repository. I'll try to fix the issue.

@probonopd probonopd merged commit 3cf686b into main Dec 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chroot builds fail to copy out binaries

4 participants