Fix wifi proxy deactivation #83
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ISSUE]
Regarding the current codebase (
adb.ts) :If there is no proxy configured on the device, the function returns a
ProxyOptionswithip=undefinedandport=0.This
ProxyOptionsis used to save the state of the wifi proxy before applying the new configuration, so that the previous state can be restored automatically :deleteSessionhook inplugin.ts)onUnexpectedShutdownhook inplugin.ts)The problem is that the ip and port are not checked before executing the adb command (so the command can be run with
ip=undefinedandport=0), resulting the proxy to not be deactivated correctly and the device to loose its internet connection.[SOLUTION]
Improve checks on the response of the adb command (
adb shell settings get global http_proxy) :undefined/:0/null, then returnsundefined(instead of aProxyOptionslike before)ip:portAlso :
getGlobalProxyValuetogetCurrentWifiProxyConfigconfigureWifiProxyandgetCurrentWifiProxyConfiggetCurrentWifiProxyConfigfunction to ensure theProxyOptionsreceived in parameter in valid : If valid, apply it, otherwise disable the proxy (adb shell settings put global http_proxy :0)logger.ts)