Skip to content

Conversation

@StevenDufresne
Copy link
Contributor

Part of DOTMSD-746.

Proposed Changes

Header Header
wpcalypso wordpress com_v2_sites_dufresnesteven6 wpcomstaging com(iPhone 14 Pro Max) calypso localhost_3000_v2_sites_abstracting blog(iPhone 14 Pro Max) (4)

Why are these changes being made?

This brings it in alignment with the other pages.

Known issues

Currently, the tabbing order is a bit weird, seeing that you tab through the description first because of how the components are structured in PageHeader. This is the same for all pages.

I'm not sure if this should change or not in a follow-up PR.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@StevenDufresne StevenDufresne requested a review from a team as a code owner November 4, 2025 01:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 4, 2025
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure I understand the problem but isn't the current behavior already correct as per the linked P2?

Image

@lucasmendes-design
Copy link

We have a definition :) it's just missing the alignment of the three dots. cc: @StevenDufresne

image

@lucasmendes-design
Copy link

Also, let's reduce the font size.

I believe the current version has Font-size: 40px. Let's use font-size: 24px.

@lucasmendes-design
Copy link

We only use font-size 40px on desktop. The rest should be 24px ✌🏽

@StevenDufresne
Copy link
Contributor Author

We only use font-size 40px on desktop. The rest should be 24px

The Hosting designs and the Automattic component library (dhW7zYBamXJIeJIE3wy5f4-fi) are technically out of sync. The <PageHeader /> heading component should be 32px and not 40px. I'm fine to deviate, but wanted to call that out.

@StevenDufresne
Copy link
Contributor Author

This layout is the direction we're going. See: p1762219198843479-slack-multi-site-dashboard.

@fushar @lucasmendes-design I would prefer to merge this change fixing the order, and address the rest in a follow-up PR more holistically.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Makes sense 👍

@StevenDufresne StevenDufresne merged commit e510632 into trunk Nov 6, 2025
14 checks passed
@StevenDufresne StevenDufresne deleted the fix/msd-adjust-overview-to-fold branch November 6, 2025 03:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2025
@fushar
Copy link
Contributor

fushar commented Nov 6, 2025

@StevenDufresne I think this PR caused a regression. The layout issue that was fixed by #106005 came back. Could we check 🤔

@StevenDufresne
Copy link
Contributor Author

@fushar I see the issue. Thanks for bringing that up.

Based on how we're using PageHeader, I don't know that we need to restrict the description length in the <PageHeader>. Maybe we can leave that up to the consumer.

I'll open a PR to discuss.

@StevenDufresne
Copy link
Contributor Author

Alright, opened one here: #106980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants