-
Notifications
You must be signed in to change notification settings - Fork 2k
MSD: Use the description for the subtitle on the overview. #106898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fushar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
We have a definition :) it's just missing the alignment of the three dots. cc: @StevenDufresne
|
|
Also, let's reduce the font size. I believe the current version has Font-size: 40px. Let's use font-size: 24px. |
|
We only use font-size 40px on desktop. The rest should be 24px ✌🏽 |
The Hosting designs and the Automattic component library (dhW7zYBamXJIeJIE3wy5f4-fi) are technically out of sync. The |
|
This layout is the direction we're going. See: p1762219198843479-slack-multi-site-dashboard. @fushar @lucasmendes-design I would prefer to merge this change fixing the order, and address the rest in a follow-up PR more holistically. |
fushar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Makes sense 👍
|
@StevenDufresne I think this PR caused a regression. The layout issue that was fixed by #106005 came back. Could we check 🤔 |
|
@fushar I see the issue. Thanks for bringing that up. Based on how we're using PageHeader, I don't know that we need to restrict the I'll open a PR to discuss. |
|
Alright, opened one here: #106980 |


Part of DOTMSD-746.
Proposed Changes
Why are these changes being made?
This brings it in alignment with the other pages.
Known issues
Currently, the tabbing order is a bit weird, seeing that you tab through the description first because of how the components are structured in
PageHeader. This is the same for all pages.I'm not sure if this should change or not in a follow-up PR.
Testing Instructions
Pre-merge Checklist