-
Notifications
You must be signed in to change notification settings - Fork 45
added ingest client abstraction #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tanmaya-panda1
wants to merge
3
commits into
feature/AddLocalFileSourceV2
Choose a base branch
from
feature/add-ingest-client-abstraction
base: feature/AddLocalFileSourceV2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+925
−48
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,12 +7,19 @@ import com.microsoft.azure.kusto.ingest.v2.common.exceptions.IngestException | |||||
| import com.microsoft.azure.kusto.ingest.v2.infrastructure.HttpResponse | ||||||
| import com.microsoft.azure.kusto.ingest.v2.models.Format | ||||||
| import com.microsoft.azure.kusto.ingest.v2.models.IngestRequestProperties | ||||||
| import com.microsoft.azure.kusto.ingest.v2.models.IngestResponse | ||||||
| import com.microsoft.azure.kusto.ingest.v2.models.StatusResponse | ||||||
| import com.microsoft.azure.kusto.ingest.v2.source.BlobSourceInfo | ||||||
| import com.microsoft.azure.kusto.ingest.v2.source.FileSourceInfo | ||||||
| import com.microsoft.azure.kusto.ingest.v2.source.SourceInfo | ||||||
| import com.microsoft.azure.kusto.ingest.v2.source.StreamSourceInfo | ||||||
| import io.ktor.http.HttpStatusCode | ||||||
| import kotlinx.serialization.SerialName | ||||||
| import kotlinx.serialization.Serializable | ||||||
| import kotlinx.serialization.json.Json | ||||||
| import java.net.ConnectException | ||||||
| import java.net.URI | ||||||
| import java.util.UUID | ||||||
|
|
||||||
| @Serializable | ||||||
| private data class StreamFromBlobRequestBody( | ||||||
|
|
@@ -27,6 +34,108 @@ class StreamingIngestClient( | |||||
| KustoBaseApiClient(engineUrl, tokenCredential, skipSecurityChecks), | ||||||
| IngestClient { | ||||||
|
|
||||||
| /** | ||||||
| * Handles multiple source types for streaming ingestion. | ||||||
| */ | ||||||
| override suspend fun submitIngestion( | ||||||
| database: String, | ||||||
| table: String, | ||||||
| sources: List<SourceInfo>, | ||||||
| format: Format, | ||||||
| ingestProperties: IngestRequestProperties?, | ||||||
| ): IngestResponse { | ||||||
| require(sources.isNotEmpty()) { "At least one source is required" } | ||||||
|
|
||||||
| // Streaming ingestion processes one source at a time | ||||||
| val source = sources.first() | ||||||
| val operationId = UUID.randomUUID().toString() | ||||||
|
|
||||||
| when (source) { | ||||||
| is BlobSourceInfo -> { | ||||||
| logger.info("Streaming ingestion from BlobSource: ${source.blobPath}") | ||||||
| submitStreamingIngestion( | ||||||
| database = database, | ||||||
| table = table, | ||||||
| data = ByteArray(0), // Not used for blob-based streaming | ||||||
| format = format, | ||||||
| ingestProperties = ingestProperties, | ||||||
| blobUrl = source.blobPath | ||||||
| ) | ||||||
| } | ||||||
| is FileSourceInfo -> { | ||||||
| logger.info("Streaming ingestion from FileSource: ${source.name}") | ||||||
| val data = source.data().readBytes() | ||||||
| submitStreamingIngestion( | ||||||
| database = database, | ||||||
| table = table, | ||||||
| data = data, | ||||||
| format = format, | ||||||
| ingestProperties = ingestProperties, | ||||||
| blobUrl = null | ||||||
| ) | ||||||
| source.close() | ||||||
| } | ||||||
| is StreamSourceInfo -> { | ||||||
| logger.info("Streaming ingestion from StreamSource: ${source.name}") | ||||||
| val data = source.data().readBytes() | ||||||
| submitStreamingIngestion( | ||||||
| database = database, | ||||||
| table = table, | ||||||
| data = data, | ||||||
| format = format, | ||||||
| ingestProperties = ingestProperties, | ||||||
| blobUrl = null | ||||||
| ) | ||||||
| source.close() | ||||||
| } | ||||||
| else -> { | ||||||
| throw IngestException( | ||||||
| message = "Unsupported source type for streaming ingestion: ${source::class.simpleName}", | ||||||
| isPermanent = true | ||||||
| ) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| // Streaming ingestion doesn't return an operation ID from the server | ||||||
| // We generate one locally for consistency with the IngestClient interface | ||||||
| return IngestResponse(ingestionOperationId = operationId) | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Note: Streaming ingestion doesn't support operation tracking. | ||||||
| * Throws UnsupportedOperationException. | ||||||
| */ | ||||||
| override suspend fun getIngestionStatus( | ||||||
| database: String, | ||||||
| table: String, | ||||||
| operationId: String, | ||||||
| forceDetails: Boolean, | ||||||
| ): StatusResponse { | ||||||
| throw UnsupportedOperationException( | ||||||
| "Streaming ingestion does not support operation status tracking. " + | ||||||
| "Operation ID: $operationId cannot be tracked. " | ||||||
|
||||||
| "Operation ID: $operationId cannot be tracked. " | |
| "Operation ID: $operationId cannot be tracked." |
Outdated
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing space at the end of the error message string. Remove the trailing space for cleaner error messages.
Suggested change
| "Operation ID: $operationId cannot be tracked. " | |
| "Operation ID: $operationId cannot be tracked." |
Outdated
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary blank lines (lines 136-138). Remove extra whitespace between method definitions for consistency.
Suggested change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: 'interface with provides' should be 'Interface that provides' or 'Interface which provides'.