Skip to content

Added a check to skip the api paths if it has PrivateEndpointConnectionProxy #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Added a check to skip the api paths if it has PrivateEndpointConnectionProxy #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/rulesets/src/native/functions/arm-resource-validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function* allResourcesHaveDelete(openapiSection: any, options: { isTracke
const allResources = options.isTrackedResource ? armHelper.getTrackedResources() : armHelper.getProxyResources()
for (const re of allResources) {
const apiPath = re.operations.find((op: any) => op.apiPath)?.apiPath
if (apiPath) {
if (apiPath && !apiPath.toLowerCase().includes("privateendpointconnectionproxies")) {
if ((options.isTrackedResource || armHelper.findOperation(apiPath, "put")) && !armHelper.findOperation(apiPath, "delete")) {
yield {
location: ["definitions", re.modelName],
Expand All @@ -53,7 +53,7 @@ export function* trackedResourcesHavePatch(openapiSection: any, options: {}, ctx
const allTrackedResources = armHelper.getTrackedResources()
for (const re of allTrackedResources) {
const apiPath = re.operations.find((op: any) => op.apiPath)?.apiPath
if (apiPath) {
if (apiPath && !apiPath.toLowerCase().includes("privateendpointconnectionproxies")) {
if (!armHelper.findOperation(apiPath, "patch")) {
yield {
location: ["definitions", re.modelName],
Expand Down
131 changes: 131 additions & 0 deletions packages/rulesets/src/native/tests/resources/armResource/trackedResourceNoDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,137 @@
"application/json"
]
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/privateendpointconnectionproxies/{privateendpointconnectionproxies}": {
"put": {
"tags": [
"privateEndpointConnectionProxies"
],
"operationId": "privateEndpointConnectionProxies_Update",
"description": "Patch HDInsight privateEndpointConnectionProxies with the specified parameters.",
"x-ms-examples": null,
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ClusterNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK response definition.",
"schema": {
"$ref": "./trackedResourceCommon.json#/definitions/Cluster"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
},
"delete": {
"tags": [
"privateEndpointConnectionProxies"
],
"operationId": "privateEndpointConnectionProxies_Delete",
"description": "Deletes the specified HDInsight privateEndpointConnectionProxies.",
"x-ms-examples": null,
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ClusterNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "Ok response definition."
},
"202": {
"description": "Accepted response definition."
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"x-ms-long-running-operation": true,
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/privateEndpointConnectionProxies": {
"get": {
"tags": [
"privateEndpointConnectionProxies"
],
"operationId": "privateEndpointConnectionProxies_ListByResourceGroup",
"description": "Lists the HDInsight privateEndpointConnectionProxies in a resource group.",
"x-ms-examples": null,
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK response definition.",
"schema": {
"$ref": "#/definitions/ClusterListResult"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
}
}
},
"definitions": {
Expand Down
177 changes: 165 additions & 12 deletions packages/rulesets/src/native/tests/resources/armResource/trackedResourceNoPatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@
"description": "HDInsight Management Client"
},
"host": "management.azure.com",
"schemes": ["https"],
"schemes": [
"https"
],
"security": [
{
"azure_auth": ["user_impersonation"]
"azure_auth": [
"user_impersonation"
]
}
],
"securityDefinitions": {
Expand All @@ -26,7 +30,9 @@
"paths": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/clusters/{clusterName}": {
"put": {
"tags": ["Clusters"],
"tags": [
"Clusters"
],
"operationId": "Clusters_Update",
"description": "Patch HDInsight cluster with the specified parameters.",
"x-ms-examples": null,
Expand Down Expand Up @@ -58,11 +64,17 @@
}
}
},
"produces": ["application/json"],
"consumes": ["application/json"]
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
},
"delete": {
"tags": ["Clusters"],
"tags": [
"Clusters"
],
"operationId": "Clusters_Delete",
"description": "Deletes the specified HDInsight cluster.",
"x-ms-examples": null,
Expand Down Expand Up @@ -95,13 +107,19 @@
}
},
"x-ms-long-running-operation": true,
"produces": ["application/json"],
"consumes": ["application/json"]
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/clusters": {
"get": {
"tags": ["Clusters"],
"tags": [
"Clusters"
],
"operationId": "Clusters_ListByResourceGroup",
"description": "Lists the HDInsight clusters in a resource group.",
"x-ms-examples": null,
Expand Down Expand Up @@ -133,8 +151,143 @@
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"produces": ["application/json"],
"consumes": ["application/json"]
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/privateendpointconnectionproxies/{privateendpointconnectionproxies}": {
"put": {
"tags": [
"privateEndpointConnectionProxies"
],
"operationId": "privateEndpointConnectionProxies_Update",
"description": "Patch HDInsight privateEndpointConnectionProxies with the specified parameters.",
"x-ms-examples": null,
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ClusterNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK response definition.",
"schema": {
"$ref": "./trackedResourceCommon.json#/definitions/Cluster"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
},
"delete": {
"tags": [
"privateEndpointConnectionProxies"
],
"operationId": "privateEndpointConnectionProxies_Delete",
"description": "Deletes the specified HDInsight privateEndpointConnectionProxies.",
"x-ms-examples": null,
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ClusterNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "Ok response definition."
},
"202": {
"description": "Accepted response definition."
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"x-ms-long-running-operation": true,
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/privateEndpointConnectionProxies": {
"get": {
"tags": [
"privateEndpointConnectionProxies"
],
"operationId": "privateEndpointConnectionProxies_ListByResourceGroup",
"description": "Lists the HDInsight privateEndpointConnectionProxies in a resource group.",
"x-ms-examples": null,
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK response definition.",
"schema": {
"$ref": "#/definitions/ClusterListResult"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"produces": [
"application/json"
],
"consumes": [
"application/json"
]
}
}
},
Expand Down Expand Up @@ -196,4 +349,4 @@
"description": "The HDInsight client API Version."
}
}
}
}
Loading