-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[PS] Migrate Nginx module to autorest v4 #28236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
To the author of the pull request, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
SpencerOfwiti
suggested changes
Aug 27, 2025
src/Nginx/Nginx.Autorest/test/Update-AzNginxCertificate.Tests.ps1
Outdated
Show resolved
Hide resolved
src/Nginx/Nginx.Autorest/test/Update-AzNginxConfiguration.Tests.ps1
Outdated
Show resolved
Hide resolved
SpencerOfwiti
suggested changes
Sep 4, 2025
some properties are deleted by mistake
SpencerOfwiti
approved these changes
Sep 8, 2025
Pan-Qi
approved these changes
Nov 5, 2025
dolauli
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autorest v4 migration
pr migrating module from generated by autorest.powershell v3 to v4
Breaking change PR migration guide provided
Add this label after the migration guide is provided by the PR owner
Breaking change PR reviewed
Add this label after a PR with breaking change has been reviewed and approved.
Contains Breaking Change
This PR contains breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.