Skip to content

fix: Propagate IOExceptions in OkHttpFluxRequestBody #47170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

fix: Propagate IOExceptions in OkHttpFluxRequestBody #47170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb0ce18
fix: Propagate IOExceptions in OkHttpFluxRequestBody
mlichtblau Nov 5, 2025
02d81c8
add Checkstyle suppression for ThrowFromClientLoggerCheck
mlichtblau Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions ...okhttp/src/main/java/com/azure/core/http/okhttp/implementation/OkHttpFluxRequestBody.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,23 @@ public void writeTo(BufferedSink bufferedSink) throws IOException {
}
}, 1, 1).then();

// The blocking happens on OkHttp thread pool.
if (callTimeoutMillis > 0) {
/*
* Default call timeout (in milliseconds). By default there is no timeout for complete calls, but
* there is for the connection, write, and read actions within a call.
*/
requestSendMono.block(Duration.ofMillis(callTimeoutMillis));
} else {
requestSendMono.block();
try {
// The blocking happens on OkHttp thread pool.
if (callTimeoutMillis > 0) {
/*
* Default call timeout (in milliseconds). By default there is no timeout for complete calls, but
* there is for the connection, write, and read actions within a call.
*/
requestSendMono.block(Duration.ofMillis(callTimeoutMillis));
} else {
requestSendMono.block();
}
} catch (RuntimeException e) {
if (e.getCause() instanceof IOException) {
throw (IOException) e.getCause();
} else {
throw e;
}
}
} else {
// Prevent OkHttp from potentially re-sending non-repeatable body outside of retry policies.
Expand Down
Loading