[Core] Fix User-Agent header value issue #36385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Azure#36383. Parenthesis are only valid to denote comments. This PR update our user agent strings to remove the OS "product" and add OS information as comments to the platform version instead.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates OS information into runtime version strings for user agent reporting across multiple packages, improving consistency and readability. The changes unify the format to follow a standard pattern: runtime/version (OS details).
Key changes:
- Merged separate OS and runtime version entries into a single combined string format
- Updated format from
key-value-keypattern to parentheticalversion (OS info)pattern - Removed standalone "OS" map entries across all platform implementations
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/servicebus/service-bus/src/util/runtimeInfo.ts | Refactored to combine runtime and OS info; added Bun/Deno runtime detection |
| sdk/servicebus/service-bus/src/util/runtimeInfo-react-native.mts | Simplified to combine react-native version with OS info in parentheses |
| sdk/core/ts-http-runtime/src/util/userAgentPlatform.ts | Combined runtime version with OS info, removed separate OS entry |
| sdk/core/ts-http-runtime/src/util/userAgentPlatform-react-native.mts | Combined react-native version with OS info, removed separate OS entry |
| sdk/core/ts-http-runtime/src/util/userAgentPlatform-browser.mts | Combined browser version with OS info, removed separate OS entry |
| sdk/core/core-rest-pipeline/src/util/userAgentPlatform.ts | Combined runtime version with OS info, removed separate OS entry |
| sdk/core/core-rest-pipeline/src/util/userAgentPlatform-react-native.mts | Combined react-native version with OS info, removed separate OS entry |
| sdk/core/core-rest-pipeline/src/util/userAgentPlatform-browser.mts | Combined browser version with OS info, removed separate OS entry |
| sdk/core/ts-http-runtime/test/node/userAgentPlatform.spec.ts | Updated tests to verify combined format and removed OS-only assertions |
| sdk/core/ts-http-runtime/test/browser/userAgentPlatform.spec.ts | Removed test for standalone OS entry |
| sdk/core/core-rest-pipeline/test/node/userAgentPlatform.spec.ts | Updated tests to verify combined format and removed OS-only assertions |
| sdk/core/core-rest-pipeline/test/browser/userAgentPlatform.spec.ts | Removed test for standalone OS entry |
Co-authored-by: Copilot <[email protected]>
Member
Author
|
@microsoft-github-policy-service rerun |
deyaaeldeen
approved these changes
Oct 30, 2025
maorleger
reviewed
Oct 30, 2025
sdk/core/core-rest-pipeline/test/node/userAgentPlatform.spec.ts
Outdated
Show resolved
Hide resolved
sdk/core/core-rest-pipeline/test/node/userAgentPlatform.spec.ts
Outdated
Show resolved
Hide resolved
jeremymeng
commented
Oct 30, 2025
sdk/core/core-rest-pipeline/test/node/userAgentPlatform.spec.ts
Outdated
Show resolved
Hide resolved
maorleger
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #36383.
Parentheses are only valid to denote comments according to RFC 9110. This PR updates our user agent strings to remove the OS "product" and add OS information as comments to the platform version instead.