Skip to content

Fix MTG generator adding extra spaces and periods in XML documentation #54027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix MTG generator adding extra spaces and periods in XML documentation #54027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
773ca40
Initial plan
Copilot Nov 19, 2025
20fcd22
Fix extra spaces and periods in MTG generated XML documentation
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/ResourceHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,29 +155,29 @@ public static void BuildEnhancedXmlDocs(InputServiceMethod serviceMethod, Format
// Request Path item
listItems.Add(new XmlDocStatement("item", [],
new XmlDocStatement("term", [$"Request Path"]),
new XmlDocStatement("description", [$"{operation.Path}"])));
new XmlDocStatement($"<description>", $"</description>", [$"{operation.Path}"])));

// Operation Id item
string operationId = GetOperationId(serviceMethod);
listItems.Add(new XmlDocStatement("item", [],
new XmlDocStatement("term", [$"Operation Id"]),
new XmlDocStatement("description", [$"{operationId}"])));
new XmlDocStatement($"<description>", $"</description>", [$"{operationId}"])));

// API Version item (if available)
var apiVersionParam = operation.Parameters.FirstOrDefault(p => p.IsApiVersion);
if (apiVersionParam != null && apiVersionParam.DefaultValue?.Value != null)
{
listItems.Add(new XmlDocStatement("item", [],
new XmlDocStatement("term", [$"Default Api Version"]),
new XmlDocStatement("description", [$"{apiVersionParam.DefaultValue.Value}"])));
new XmlDocStatement($"<description>", $"</description>", [$"{apiVersionParam.DefaultValue.Value}"])));
}

// Resource item (if enclosing type is a ResourceClientProvider)
if (enclosingType is ResourceClientProvider resourceClient)
{
listItems.Add(new XmlDocStatement("item", [],
new XmlDocStatement("term", [$"Resource"]),
new XmlDocStatement("description", [$"{resourceClient.Type:C}"])));
new XmlDocStatement($"<description>", $"</description>", [$"{resourceClient.Type:C}"])));
}

// Create the list statement
Expand Down