docs: add comments on instance garbage collection reasonings and suggestions #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comtalyst
force-pushed
the
comtalyst/garbage-collection-comments
branch
from
26e72aa to
24857fe
Compare
comtalyst
changed the base branch from
comtalyst/fix-generatenodeclaimname
to
main
matthchr
reviewed
Oct 30, 2025
| })...) | ||
| errs := make([]error, len(retrieved)) | ||
| workqueue.ParallelizeUntil(ctx, 100, len(managedRetrieved), func(i int) { | ||
| // managedRetrieved, although represented as NodeClaim, is actually actually populated by provider.List() rather than sourcing from the cluster. |
Member
There was a problem hiding this comment.
I think that Karpenter upstream does this a lot - for example the entire existence of cloudProvider.List and its implementation is coercing VMs into NodeClaims, rather than sourcing this data from the NodeClaim.
I think calling this out is good but I am not sure it makes sense to ask "should we change" since I think the whole CloudProvider interface is somewhat predicated on this being "the way it's done". It has confused me slightly a few times too.
| // This 5m is more of a grace period for newly-created instances that have yet to populate NodeClaim after. | ||
| time.Since(managedRetrieved[i].CreationTimestamp.Time) > time.Minute*5 { | ||
| errs[i] = c.garbageCollect(ctx, managedRetrieved[i], nodeList) | ||
| // In the case that CreationTimestamp is irretrievable (epoch), grace period will effectively be disabled. |
Member
There was a problem hiding this comment.
Not sure I am following this bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Add some comments on instance garbage collection. See the changes for details.
How was this change tested?
Does this change impact docs?
Release Note