refactor: designate VM instance-specific acceptance tests #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comtalyst
force-pushed
the
comtalyst/vm-instance-renames
branch
2 times, most recently
from
03cec38 to
6080df2
Compare
comtalyst
force-pushed
the
comtalyst/designate-vm-acceptance-tests
branch
from
82a0292 to
b6184df
Compare
3 tasks
comtalyst
force-pushed
the
comtalyst/designate-vm-acceptance-tests
branch
from
b6184df to
edd7054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Upcoming Machine API integration will introduce a kind of instance with different assumptions than VM instances, which is the only supported type as of today.
Most of the existing acceptance tests are not immediately compatible with this new assumption.
This PR will designate those tests as tests specific to VM instances, so that Machine API integration changes can add new ones with clear distinction.
A considered alternative was to refactor the tests to be more generic. Although, given that each test has different degree of incompatibility, it is estimated to not be worth it.
How was this change tested?
Does this change impact docs?
Release Note