Skip to content

Conversation

@alexchuber
Copy link
Contributor

This PR adds handling for a Blob object in createImageBitmap.

We should probably outright remove the Blob hack from here, but just to quickly & safely unblock these other changes, I hope this is alright.

@alexchuber alexchuber requested a review from bghgary November 7, 2025 02:13
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@alexchuber alexchuber enabled auto-merge (squash) November 7, 2025 02:17
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will let the native team comment on this

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2025

@alexchuber alexchuber merged commit caeae1c into master Nov 7, 2025
20 checks passed
@alexchuber alexchuber deleted the support-blob-createimagebitmap branch November 7, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants