-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Optionally enable GenAI telemetry following semantic conventions (#1… #13105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
) * Merge changes from otel_semconvs branch, adjust to match updated main * Linting updates * Linting updates * Lowest google-cloud-aiplatform to support protobuf 5 * make metrics enabled by default * Revert "make metrics enabled by default" This reverts commit 7e67477. * Lowest version of sdk to support metrics * update poetry lock file --------- Co-authored-by: Krish Dholakia <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugbot free trial expires on August 9, 2025
Learn more in the Cursor dashboard.
|
|
||
| metrics.set_meter_provider(meter_provider) | ||
|
|
||
| self._operation_duration_histogram = meter.create_histogram( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Metrics Initialization Uses Incorrect Provider
In the _init_metrics method, when meter_provider is None, a new MeterProvider instance is created. However, the meter is then retrieved using the global get_meter() function before the newly created provider is set as the global one. This causes metrics to be associated with the previously set or default global meter provider instead of the intended new instance. The meter should be obtained directly from the newly created meter_provider instance.
Locations (1)
Co-authored-by: krrishdholakia <[email protected]>
|
|
Bugbot found 2 bugsTo see them, activate your membership in the Cursor dashboard. |
…I/litellm into litellm_dev_07_29_2025_p2
Remove Semantic Convention Dependency
fix log event_name for llm response
…2626)
Merge changes from otel_semconvs branch, adjust to match updated main
Linting updates
Linting updates
Lowest google-cloud-aiplatform to support protobuf 5
make metrics enabled by default
Revert "make metrics enabled by default"
This reverts commit 7e67477.
Lowest version of sdk to support metrics
update poetry lock file
Title
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes