Skip to content

Conversation

@krrishdholakia
Copy link
Contributor

…2626)

  • Merge changes from otel_semconvs branch, adjust to match updated main

  • Linting updates

  • Linting updates

  • Lowest google-cloud-aiplatform to support protobuf 5

  • make metrics enabled by default

  • Revert "make metrics enabled by default"

This reverts commit 7e67477.

  • Lowest version of sdk to support metrics

  • update poetry lock file


Title

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test

Changes

)

* Merge changes from otel_semconvs branch, adjust to match updated main

* Linting updates

* Linting updates

* Lowest google-cloud-aiplatform to support protobuf 5

* make metrics enabled by default

* Revert "make metrics enabled by default"

This reverts commit 7e67477.

* Lowest version of sdk to support metrics

* update poetry lock file

---------

Co-authored-by: Krish Dholakia <[email protected]>
@vercel
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
litellm Ready Ready Preview Comment Aug 28, 2025 10:05pm

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on August 9, 2025
Learn more in the Cursor dashboard.


metrics.set_meter_provider(meter_provider)

self._operation_duration_histogram = meter.create_histogram(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Metrics Initialization Uses Incorrect Provider

In the _init_metrics method, when meter_provider is None, a new MeterProvider instance is created. However, the meter is then retrieved using the global get_meter() function before the newly created provider is set as the global one. This causes metrics to be associated with the previously set or default global meter provider instead of the intended new instance. The meter should be obtained directly from the newly created meter_provider instance.

Locations (1)
Fix in Cursor Fix in Web

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ keith-decker
✅ krrishdholakia
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

@cursor
Copy link

cursor bot commented Aug 12, 2025

Bugbot found 2 bugs

To see them, activate your membership in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants