-
Notifications
You must be signed in to change notification settings - Fork 42
Experimenting with github forms syntax from decision points #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ahouseholder
commented
Nov 14, 2025
- resolves Demonstrate SSVC integration into GitHub Issue Forms #1036
| # DM24-0278 | ||
|
|
||
| """ | ||
| Provides TODO writeme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add file docstring
| """ | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove main() etc.
| # DM24-0278 | ||
|
|
||
| """ | ||
| Provides TODO writeme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add file docstring
| from ssvc.registry import get_registry | ||
|
|
||
|
|
||
| class GhFormCheckboxOption(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split GhForm* classes into their own separate module for maintenance
| return cb | ||
|
|
||
|
|
||
| def json_to_yaml(json_str: str) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move json_to_yaml to a utils or helper module
| return yaml.dump(data, sort_keys=False) | ||
|
|
||
|
|
||
| def expand_dps( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move expand_dps to a utils or helper module, this will be useful elsewhere.
Also consider making outcome exclusion optional at the top level