Fix logging bug, add access to temp_log_options(), and add logging tests. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choppsv1
force-pushed
the
chopps/templog+test
branch
2 times, most recently
from
31ed836 to
903661a
Compare
rjarry
requested changes
Oct 16, 2025
libyang/log.py
Outdated
Comment on lines
34
to
35
| _ffi = cffi.FFI() | ||
| opts = _ffi.new("uint32_t *", opt) |
Collaborator
There was a problem hiding this comment.
You already have an ffi object available and imported, use it instead of creating a new one.
opts = ffi.new("uint32_t *", opt)
Collaborator
Author
There was a problem hiding this comment.
not sure why I did that, anyway, fixed.
tests/test_log.py
Outdated
Comment on lines
1
to
7
| # -*- coding: utf-8 eval: (blacken-mode 1) -*- | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # July 7 2025, Christian Hopps <[email protected]> | ||
| # | ||
| # Copyright (c) 2025, LabN Consulting, L.L.C. | ||
| # |
Collaborator
There was a problem hiding this comment.
Can you follow the same license header than in all files please?
The arg is added as `str` but the fmt requires `int`, causes exception when turning on python logging -- fix. Signed-off-by: Christian Hopps <[email protected]>
When one wishes to disable logging temporarily (e.g., when calling API functions
when an error result is expected and OK), libyang provides
ly_temp_log_options(). We need access to this in python, so export access to the
function and add a python context (i.e., "with") manager API for using
it idiomatically as well.
ex usage:
```
with temp_log_options(0):
ly_unwanted_logging_call();
```
Signed-off-by: Christian Hopps <[email protected]>
Add a new log unit test. Add a test for the newly exposed temp_log_options() function as well as the already implemented configure_logging() function. Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
chopps/templog+test
branch
from
903661a to
4211c19
Compare
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with logging - the line arg is added as
strbut the fmt requiresint, which causes exception when turning on python logging -- fixed.Add temp_log_options() API access - when one wishes to disable logging temporarily (e.g., when calling API functions when an error result is expected and OK), libyang provides ly_temp_log_options() -- add access to the function:
ex usage: