BFD-4429: Add Missing Provider #2908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dzeda
reviewed
Dec 3, 2025
apps/bfd-server-ng/src/main/java/gov/cms/bfd/server/ng/claim/model/BillingProvider.java
Outdated
Show resolved
Hide resolved
victor-chaparro
requested review from
aschey-forpeople,
malessi,
mel1-G and
mjburling
as code owners
Contributor
|
Can you add additional tests for: |
# Conflicts: # apps/bfd-pipeline/bfd-pipeline-idr/test_samples2/professional/SYNTHETIC_CLM.csv # apps/bfd-server-ng/src/test/java/gov/cms/bfd/server/ng/__snapshots__/EobReadIT.snap # apps/bfd-server-ng/src/test/java/gov/cms/bfd/server/ng/__snapshots__/EobSearchIT.snap
apps/bfd-server-ng/src/main/java/gov/cms/bfd/server/ng/claim/model/BillingProvider.java
Outdated
Show resolved
Hide resolved
apps/bfd-server-ng/src/main/java/gov/cms/bfd/server/ng/claim/model/ProviderHistory.java
Outdated
Show resolved
Hide resolved
aschey-forpeople
approved these changes
Dec 4, 2025
|
mel1-G
approved these changes
Dec 5, 2025
mjburling
changed the title
Member
|
This PR was erroneously submitted and accepted under BFD-4229. This has since been corrected here and in the 2.228.0 release notes. However, the commit to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4429
What Does This PR Do?
This PR removes the unnecessary claim-type check when adding a billing practitioner. Provider assignment now depends solely on the NPI type.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.