-
Notifications
You must be signed in to change notification settings - Fork 993
New Cropper across the app #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
5ef0e0e
New Cropper, updated CaptureArea window
ItsEeleeya 7d49155
Fix capture-area nswindow layer, close button on CapErrorBoundary, Re…
ItsEeleeya 8b2bf1d
Remove unused CropAreaRenderer and Box.
ItsEeleeya 2ea420d
Add default capability "core:resources:allow-close" to properly close…
ItsEeleeya 94355eb
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya 8ed99c8
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya 82dfbd4
Properly disable Confirm button when crop size is too small
ItsEeleeya 292e7bc
Cropper double click,
ItsEeleeya 19f93a3
Use new cropper in target-select-overlay
ItsEeleeya 4f43b4c
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya b1dedce
Don't fill when double clicking selected region. Only the container
ItsEeleeya 0640f65
oops
ItsEeleeya 2cb06e0
Ensure editor project has a first segment in editor cropper, better i…
ItsEeleeya 7590079
Delete canvas.ts
ItsEeleeya 4037382
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya c8acdb7
Remove unused calculations in Cropper
ItsEeleeya c2d58b1
Add hard minSize to target-select-overlay cropper, apply ratio snappi…
ItsEeleeya e5e2d5c
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya 1d4c47d
Ensure the new selection controls can't go under the notch on macos
ItsEeleeya a207b5f
Merge branch 'main' into unified-cropper
ameer2468 4572861
Merge branch 'main' into pr/1079
richiemcilroy 1f4687f
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya 0d0ec6d
Update tauri.ts
ItsEeleeya 6898d52
Update general.tsx
ItsEeleeya dd8d0d3
nit
oscartbeaumont 3480e66
move event def to Rust
oscartbeaumont 61d5b16
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya 1e83773
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya befbdf5
(Fix) Use the new cropper again in target-select-overlay
ItsEeleeya 246021f
Cropper: Stop resizing in aspect ratio mode towards the opposite side.
ItsEeleeya caf671c
Add alt mode indicator
ItsEeleeya a393daf
fix the close button i broke
ItsEeleeya 3b486c3
Add minimum size warning
ItsEeleeya da52a78
Ensure `createKeyDownSignal` handles blur event
ItsEeleeya e44d930
Fix "ResizeObserver loop completed with undelivered notifications."
ItsEeleeya 9288065
Merge remote-tracking branch 'upstream/main' into unified-cropper
ItsEeleeya 0147048
biome
ameer2468 41edf40
render latest frame in the cropper and pause playback when opening it
ameer2468 9345ef7
some tweaks
ameer2468 359557d
rendering current would have drawbacks
ameer2468 7c557d0
Merge branch 'main' into unified-cropper
ameer2468 aa822a2
ts
ameer2468 e8ef427
use named export + attach pointermove to window instead of container
Brendonovich fcd03b6
formatting
Brendonovich e5705f8
final fixes
Brendonovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.