Skip to content

Conversation

@johnnynunez
Copy link
Contributor

This pull request includes updates to the CI workflow configuration in the .github/workflows/ci.yml file. The most important changes involve modifying the build and artifact creation steps to streamline the process and ensure consistency across different operating systems.

Improvements to build configuration:

  • Removed the -DCMAKE_BUILD_TYPE=Release flag from the cmake configuration command to simplify the build setup.
  • Replaced the cmake --build command with ninja -C build for building the project, which aligns with the use of Ninja as the build system.

Enhancements to artifact creation:

  • Updated the Windows artifact creation step to simplify the directory structure and file naming, ensuring the castxml binary is correctly archived.
  • Modified the Non-Windows artifact creation step to streamline the tarball creation process and ensure the castxml binary is correctly archived and compressed.
  • Adjusted the artifact upload path to match the new artifact naming convention, ensuring the correct files are uploaded.

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Feb 13, 2025

CC @thewtex if you can merge it ASAP and upload new artifacts.
the actual artifacts only upload binary castxml so it's wrong, now is fixed

@johnnynunez
Copy link
Contributor Author

cc @thewtex you can check that now it's correct
https://github.com/johnnynunez/CastXMLSuperbuild/actions/runs/13316364328

@thewtex
Copy link
Contributor

thewtex commented Feb 13, 2025

cc @thewtex you can check that now it's correct https://github.com/johnnynunez/CastXMLSuperbuild/actions/runs/13316364328

@johnnynunez when I tried to open one of these, I found that it was a tarball in a zip:

.rwxrwxrwx matt matt  50 MB Thu Feb 13 17:29:04 2025  castxml-ubuntu-22.04-x86_64.zip
❯ aunpack castxml-ubuntu-22.04-x86_64.zip
Archive:  castxml-ubuntu-22.04-x86_64.zip
  inflating: Unpack-2447/castxml-ubuntu-22.04-x86_64.tar.gz
castxml-ubuntu-22.04-x86_64.zip: extracted to `castxml-ubuntu-22.04-x86_64.tar.gz'

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Feb 13, 2025

cc @thewtex you can check that now it's correct https://github.com/johnnynunez/CastXMLSuperbuild/actions/runs/13316364328

@johnnynunez when I tried to open one of these, I found that it was a tarball in a zip:

.rwxrwxrwx matt matt  50 MB Thu Feb 13 17:29:04 2025  castxml-ubuntu-22.04-x86_64.zip
❯ aunpack castxml-ubuntu-22.04-x86_64.zip
Archive:  castxml-ubuntu-22.04-x86_64.zip
  inflating: Unpack-2447/castxml-ubuntu-22.04-x86_64.tar.gz
castxml-ubuntu-22.04-x86_64.zip: extracted to `castxml-ubuntu-22.04-x86_64.tar.gz'

It's correct. upload artifact only upload .zip https://github.com/actions/upload-artifact#zip-archives
lower versions upload other formats, but v3 was deprecated in January 2025

old upload:
zip -> tar.gz -> castxml binaries
new upload:
zip -> tar.gz -> castxml binaries + shared folder + other folders necessaries to run it

@johnnynunez
Copy link
Contributor Author

I'ts fixed in pygccxml unzip + tar.gz

@thewtex
Copy link
Contributor

thewtex commented Feb 14, 2025

It's correct. upload artifact only upload .zip https://github.com/actions/upload-artifact#zip-archives lower versions upload other formats, but v3 was deprecated in January 2025

old upload: zip -> tar.gz -> castxml binaries new upload: zip -> tar.gz -> castxml binaries + shared folder + other folders necessaries to run it

@johnnynunez 👍 Ok, but I will unpack the zip for the releases because that is what we had previously and what people expect and need.

@thewtex thewtex merged commit d3060b0 into CastXML:master Feb 14, 2025
7 checks passed
@johnnynunez
Copy link
Contributor Author

It's correct. upload artifact only upload .zip https://github.com/actions/upload-artifact#zip-archives lower versions upload other formats, but v3 was deprecated in January 2025
old upload: zip -> tar.gz -> castxml binaries new upload: zip -> tar.gz -> castxml binaries + shared folder + other folders necessaries to run it

@johnnynunez 👍 Ok, but I will unpack the zip for the releases because that is what we had previously and what people expect and need.

super, thanks!

@thewtex
Copy link
Contributor

thewtex commented Feb 14, 2025

@johnnynunez all set:

https://github.com/CastXML/CastXMLSuperbuild/releases/tag/v0.6.11.post1

thanks for the follow-up 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants