-
Notifications
You must be signed in to change notification settings - Fork 14
[BUG] FIX ARTIFACTS #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CC @thewtex if you can merge it ASAP and upload new artifacts. |
|
cc @thewtex you can check that now it's correct |
@johnnynunez when I tried to open one of these, I found that it was a tarball in a zip: |
It's correct. upload artifact only upload .zip https://github.com/actions/upload-artifact#zip-archives old upload: |
|
I'ts fixed in pygccxml unzip + tar.gz |
@johnnynunez 👍 Ok, but I will unpack the zip for the releases because that is what we had previously and what people expect and need. |
super, thanks! |
|
@johnnynunez all set: https://github.com/CastXML/CastXMLSuperbuild/releases/tag/v0.6.11.post1 thanks for the follow-up 🥇 |
This pull request includes updates to the CI workflow configuration in the
.github/workflows/ci.ymlfile. The most important changes involve modifying the build and artifact creation steps to streamline the process and ensure consistency across different operating systems.Improvements to build configuration:
-DCMAKE_BUILD_TYPE=Releaseflag from thecmakeconfiguration command to simplify the build setup.cmake --buildcommand withninja -C buildfor building the project, which aligns with the use of Ninja as the build system.Enhancements to artifact creation:
castxmlbinary is correctly archived.castxmlbinary is correctly archived and compressed.