Support CAIP-25 style session proposal handling #2734
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://specs.walletconnect.com/2.0/specs/clients/sign/session-proposal
https://reown.com/blog/caip-25-implementation-guidance-migrating-to-empty-undefined-required-namespaces
Summary
Why this change
WalletConnect is migrating to align with the CAIP-25 standard, which treats all namespace requests as optional for better UX.
What's changing
Old pattern
dApps use
requiredNamespaces(must support or connection fails)New pattern
dApps use
optionalNamespacesonly, leavingrequiredNamespacesempty/undefinedThis allows wallets to approve connections even when they don't support all requested chains
This PR still supports
requiredNamespaces, because many dApps haven't migrated yet, so we need backward compatibility.