Skip to content

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 11, 2025

Purpose:

Add support for v2 plots to the Plot class. This is part of the plot sync protocol and the harvester protocol. In order to support v2 plots, we need a strength field, but we also need to stay backwards compatible with previous versions of harvesters. e.g. DrPlotter.

In order to do so, the size field is reused to now either have the v1 plot size or the v2 plot strength. The most significant bit in the uint8 field determines which one it is.

The field was renamed from size to param to match the naming of similar fields in other parts of the code.

Current Behavior:

the plot sync protocol does not support v2 plots.

New Behavior:

the plot sync protocol supports v2 plots

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 11, 2025
@arvidn
Copy link
Contributor Author

arvidn commented Nov 11, 2025

maybe the harvester protocol version number should be bumped

@arvidn arvidn requested a review from almogdepaz November 11, 2025 06:38
@arvidn arvidn marked this pull request as ready for review November 11, 2025 06:38
@arvidn arvidn requested a review from a team as a code owner November 11, 2025 06:38
@arvidn arvidn requested a review from almogdepaz November 13, 2025 10:39
@arvidn arvidn force-pushed the v2-plot-sync branch 6 times, most recently from 9d6ba6d to b69a9d4 Compare November 13, 2025 13:58
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/harvester/harvester.py 50.0% lines 200-201
chia/plot_sync/sender.py 66.7% lines 45-46
chia/protocols/harvester_protocol.py 80.0% lines 161
Total Missing Coverage
22 lines 5 lines 77%

@arvidn
Copy link
Contributor Author

arvidn commented Nov 13, 2025

the missing test coverage is because we don't have any v2 plots in CI yet. This will be addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants