Fix OS Discovery Tool Windows for Nvidia GPU detection #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue in the PowerShell script for detecting NVIDIA GPU drivers and their modes (Graphics or Compute). The current script "getWindowsOsInvToIntersight.ps1" has an error with the nvidia-smi command that prevents it from executing correctly in a remote PowerShell context.
Issue Resolved
Fixed the error where when a GPU (NVIDIA A100 in my lab) was unable to identify the model (TCC or WDDM) and a null value was being registered in the key. Due to this, the HCL part of Intersight was not being populated.
What was changed
Corrected Command Construction: Removed single quotes around the path to nvidia-smi.exe when constructing the command string. Proper escaping is applied to handle spaces in paths. Also "no header" was changed to "noheader".
Fixed Command Execution with Invoke-Expression: Modified how the nvidia-smi command is executed using Invoke-Expression to ensure it runs correctly in a remote session via Invoke-Command.