#128 Allow specifying empty lists of maps #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, toBody() does not distinuish between list-of-maps attributes being null and empty. This results in the provider omitting the attribute from the API request when the value is an empty list, making it impossible for the user to clear a list of maps. Handling of lists of primitive values like strings does not have this issue - attributes with an empty list value are included in the request while ones with a null value are skipped. Change the check to only omit list-of-maps attributes with null values.
vozhyk-
force-pushed
the
128-allow-specifying-empty-lists-of-maps
branch
from
2ccafd3 to
6a13129
Compare
|
Please can we target this for 1.8.1 release @danischm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, toBody() does not distinuish between list-of-maps attributes
being null and empty.
This results in the provider omitting the attribute from the API request
when the value is an empty list,
making it impossible for the user to clear a list of maps.
Handling of lists of primitive values like strings
does not have this issue -
attributes with an empty list value are included in the request
while ones with a null value are skipped.
Change the check to only omit list-of-maps attributes with null values.
Note:
organization_extensions_thousand_eyes_networkstill has customized code withlen(), but changing that would not change the behavior.Tested for:
meraki_appliance_inbound_firewall_rules;meraki_appliance_l7_firewall_rules;meraki_appliance_one_to_many_nat_rules:rules;rules[].port_rules: the API returns an error if the list is empty (https://github.com/netascode/terraform-meraki-nac-meraki/pull/124/files#r2533982746);meraki_appliance_one_to_one_nat_rules:rules;rules[].allowed_inbound;meraki_appliance_port_forwarding_rules;meraki_appliance_security_malware:allowed_urls;allowed_files;meraki_appliance_single_lan:ipv6_prefix_assignments: the API ignores the[]value and keeps one prefix assignment; the provider does not notice this (https://github.com/netascode/terraform-meraki-nac-meraki/pull/124/files#r2534009799).Fixes #128