Addition of resource and data source for service chaining under contract in template (DCNE-312) #388
Conversation
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
github-actions
bot
changed the title
|
|
||
| ## GUI Information ## | ||
|
|
||
| * `Location` - Manage -> Manage -> Tenant Template -> Applications -> Schemas -> <Schema Name> -> <Template Name> -> Contracts -> <Contract Name> -> Service Chaining |
| "node_filter": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "allow-all", |
There was a problem hiding this comment.
just for understanding this default is needed for testing, or does NDO allow creation when the value is unset?
There was a problem hiding this comment.
NDO sets it allow-all during creation when unset..
There was a problem hiding this comment.
but is computed not supposed to handle this?
There was a problem hiding this comment.
I also want to avoid any unforeseen challenges with the testing framework of sdkv1.
There was a problem hiding this comment.
Ok I do not not think we should adjust code logic because a old legacy testing framework is not working as expected. Can we ignore the failing tests and rely on our standard not provide and let API handle defaults?
| serviceNodesPayload := make([]interface{}, 0, len(serviceNodes)) | ||
| for i, sn := range serviceNodes { | ||
| node := sn.(map[string]interface{}) | ||
| idx := i + 1 |
There was a problem hiding this comment.
why assign as variable when only used single time in nodePayload?
| * `id` - (Read-Only) The unique Terraform identifier of the service chain. | ||
| * `name` - (Read-Only) The name of the service chain, derived from the contract name. | ||
| * `node_filter` - (Read-Only) The node filter configured for the service chain. | ||
| * `service_nodes` - (Read-Only) A list of service nodes that form the service chain. Each element has the following attributes: |
There was a problem hiding this comment.
Can this be rephrased to say what service_nodes parameter does?
| * `uuid` - (Read-Only) The NDO UUID of the service node instance within the chain. | ||
| * `consumer_connector` - (Read-Only) A list containing the consumer-side connection block. | ||
| * `interface_name` - (Read-Only) The name of the consumer connector interface. | ||
| * `is_redirect` - (Read-Only) Whether the consumer connector is a redirect. |
There was a problem hiding this comment.
rephase the sentence:
(when is_redirect parameter is set to true then what does consumer_connector do?)
| * `is_redirect` - (Read-Only) Whether the consumer connector is a redirect. | ||
| * `provider_connector` - (Read-Only) A list containing the provider-side connection block. | ||
| * `interface_name` - (Read-Only) The name of the provider connector interface. | ||
| * `is_redirect` - (Read-Only) Whether the provider connector is a redirect. |
There was a problem hiding this comment.
rephase the sentence:
(when is_redirect parameter is set to true then what does provider_connector do?)
| * `schema_id` - (Required) The ID of the schema where the contract resides. | ||
| * `template_name` - (Required) The name of the template where the contract resides. | ||
| * `contract_name` - (Required) The name of the contract to which this service chain will be applied. | ||
| * `node_filter` - (Optional) The node filter for the service chain. Defaults to allow-all. |
| * `device_ref` - (Required) The NDO UUID of the mso_service_device_cluster to be used for this node. | ||
| * `consumer_connector` - (Required) A block that defines the consumer-side connection for the service node. | ||
| * `interface_name` - (Required) The name of the interface on the service device cluster that will act as the consumer connector. | ||
| * `is_redirect` - (Optional) Specifies if the connector is a redirect. Defaults to false. |
| * `is_redirect` - (Optional) Specifies if the connector is a redirect. Defaults to false. | ||
| * `provider_connector` - (Required) A block that defines the provider-side connection for the service node. | ||
| * `interface_name` - (Required) The name of the interface on the service device cluster that will act as the provider connector. | ||
| * `is_redirect` - (Optional) Specifies if the connector is a redirect. Defaults to false. |
|
|
||
| # mso_schema_template_contract_service_chaining # | ||
|
|
||
| Manages Schema Template Contract Service Chaining on Cisco Nexus Dashboard Orchestrator (NDO). |
There was a problem hiding this comment.
Can you mention the NDO version?
| * `contract_name` - (Required) The name of the contract to which this service chain will be applied. | ||
| * `node_filter` - (Optional) Specifies the name of a filter used to selectively redirect a subset of the contract-permitted traffic through the service chain. Allowed values are allow-all and filters-from-contract. | ||
| * `service_nodes` - (Required) A list of the service nodes that constitute the service chain, presented in their processing order. Each element details the configuration of a single service node. | ||
| * `name` - (Required) A unique name for the service node within the chain. |
There was a problem hiding this comment.
The service node name is managed by the NDO when we create/delete the service chain. Can we make it as read only attribute?
There was a problem hiding this comment.
The name can be changed via API. Are you referring to the service chaining name?
…ing under contract in template
…ct_service_chaining
…ding options to node_filter
…by changing descriptions
…y adding supported NDO version
… schema_template_contract_service_chaining
7 participants
No description provided.