Addition of resource and data source for Custom QoS Policy under tenant policies (DCNE-283) #401
+1,366
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
github-actions
bot
changed the title
akinross
requested changes
Nov 20, 2025
|
|
||
| # mso_custom_qos_policy # | ||
|
|
||
| Data source for Custom Quality of Service (QoS) Policy. This resource is supported in NDO v4.3 and higher. |
Collaborator
There was a problem hiding this comment.
here the abbreviation is the other way around, can you make it consistent? or other way around in the other lines
Suggested change
| Data source for Custom Quality of Service (QoS) Policy. This resource is supported in NDO v4.3 and higher. | |
| Data source for Custom QoS (Quality of Service) Policy. This resource is supported in NDO v4.3 and higher. |
…licy under tenant policies
gmicol
requested changes
Nov 24, 2025
Comment on lines
216
to
228
| func convertCosValue(value string) string { | ||
| if mapped, ok := targetCosMap[value]; ok { | ||
| return mapped | ||
| } | ||
| return value | ||
| } | ||
|
|
||
| func convertDscpValue(value string) string { | ||
| if mapped, ok := targetDscpMap[value]; ok { | ||
| return mapped | ||
| } | ||
| return value | ||
| } |
Collaborator
There was a problem hiding this comment.
Shouldn't we combine these two functions into a more general function in utils.go that could be used in future resources?
Comment on lines
230
to
246
| func reverseCosMap(value string) string { | ||
| for k, v := range targetCosMap { | ||
| if v == value { | ||
| return k | ||
| } | ||
| } | ||
| return value | ||
| } | ||
|
|
||
| func reverseDscpMap(value string) string { | ||
| for k, v := range targetDscpMap { | ||
| if v == value { | ||
| return k | ||
| } | ||
| } | ||
| return value | ||
| } |
Collaborator
There was a problem hiding this comment.
Shouldn't we combine these two functions into a more general function in utils.go that could be used in future resources?
…policy generic by moving them to utils.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.