-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add islessgreater() term entry for C++ math-functions #8010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mamtawardhani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ylevental, I've requested some changes
|
|
||
| - `x`: A floating-point or integer value to compare. | ||
| - `y`: A floating-point or integer value to compare. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a Bold heading Return value:
content/cpp/concepts/math-functions/terms/islessgreater/islessgreater.md
Outdated
Show resolved
Hide resolved
content/cpp/concepts/math-functions/terms/islessgreater/islessgreater.md
Outdated
Show resolved
Hide resolved
Added documentation for the islessgreater() function including: - Description and syntax - Example usage - Codebyte example with edge cases Fixes Codecademy#7996
Updated description to meet line length requirements for Prettier formatting check.
79ecf6f to
26696de
Compare
|
Hi @mamtawardhani, Thank you for taking the time to review this PR and provide detailed feedback. I've attempted to implement all three of your requested changes:
I also added a Parameters: heading to match the formatting style used in similar entries like However, I found the process of trying to address the line-specific feedback while maintaining CI compliance to be quite challenging. The line numbers shifted as I restructured the file to match the repo's formatting standards, and the review comments weren't automatically marked as outdated, which made it difficult to track what still needed to be addressed. For future contributions, I think it would be more efficient if reviewers could either:
I'm going to close this PR for now as I'd like to focus on other issues. I appreciate your time and feedback, and I hope this experience helps improve the review process for future contributors. Thank you! |
Added documentation for the
islessgreater()function including:Description
This PR adds a new term entry for the
islessgreater()function under C++ math-functions as requested in issue #7996. The documentation provides a comprehensive overview of this function, which determines whether a value is less than or greater than another without raisingFE_INVALIDexceptions. The entry includes detailed explanations of how this function safely handlesNaNvalues, along with practical examples demonstrating its usage with different floating-point types.Issue Solved
Closes #7996
Type of Change
Checklist
mainbranch.Issues Solvedsection.