Skip to content

Conversation

@Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 1, 2024

Summary

Add SDK banner support

Will affect visual aspect of the product

YES

Screenshots

image

image

image

Test instructions

Must be used with https://github.com/Codeinwp/themeisle-sdk/pull/269

  • Set the instance date between 25 NOV and 3 DEC to trigger Black Friday banner
  • You should see the banner on the Library page.
  • You should NOT see the banner if it is not a Blackfriday Interval

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/themeisle/issues/1688

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 1, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 1, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 1, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 1, 2024

Plugin build for bd3d930 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/banner-support branch 3 times, most recently from 8c49fb8 to 2afc4cf Compare November 1, 2024 14:19
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as draft November 4, 2024 09:22
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 5, 2024 09:08
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/banner-support branch 2 times, most recently from 43d01af to 580c25d Compare November 6, 2024 10:57
@vytisbulkevicius vytisbulkevicius merged commit 940a160 into development Nov 11, 2024
8 checks passed
@vytisbulkevicius vytisbulkevicius deleted the feat/banner-support branch November 11, 2024 14:52
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants