Skip to content

feat: improve customizer search visibility #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HardeepAsrani merged 2 commits into from
Nov 21, 2025
Merged

feat: improve customizer search visibility #4456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30f9ef3
feat: improve customizer search visibility
HardeepAsrani Nov 13, 2025
63ec9fd
chore: fix jslint
HardeepAsrani Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions assets/apps/customizer-controls/src/customizer-search/MainSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { createPortal } from '@wordpress/element';
import React, { useState } from 'react';
import SearchToggle from './SearchToggle';
import SearchComponent, { Control } from './SearchComponent';
import SearchResults from './SearchResults';

Expand All @@ -19,24 +18,14 @@
* @param {MainSearchProps} MainSearchProps
* @class
*/
const MainSearch: React.FC<MainSearchProps> = ({ search, button, results }) => {

Check warning on line 21 in assets/apps/customizer-controls/src/customizer-search/MainSearch.tsx

View workflow job for this annotation

GitHub Actions / npm (16.x) 

'button' is defined but never used
const [isOpened, setIsOpened] = useState(false);
const [query, setQuery] = useState('');
const [matchResults, setMatchResults] = useState([] as Control[]);

return (
<>
{createPortal(
<SearchToggle
onToggle={() => {
setIsOpened(!isOpened);
}}
/>,
button
)}
{createPortal(
<SearchComponent
isOpened={isOpened}
search={query}
setSearch={setQuery}
matchResults={matchResults}
Expand Down
29 changes: 3 additions & 26 deletions assets/apps/customizer-controls/src/customizer-search/SearchComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ declare global {
* Type SearchComponentProps
*/
type SearchComponentProps = {
isOpened: boolean;
search: string;
setSearch: (value: string) => void;
matchResults: Control[];
Expand All @@ -75,7 +74,6 @@ type SearchComponentProps = {
* @class
*/
const SearchComponent: React.FC<SearchComponentProps> = ({
isOpened,
search,
setSearch,
matchResults,
Expand Down Expand Up @@ -128,24 +126,6 @@ const SearchComponent: React.FC<SearchComponentProps> = ({
});
}, []);

/**
* This `useEffect()` is being used to listen for the toggleEvent
* from `SearchToggle` component.
*/
useEffect(() => {
if (isOpened) {
document
.getElementById('neve-customize-search-field')
?.classList.add('visible');
document.getElementById('nv-customizer-search-input')?.focus();
} else {
document
.getElementById('neve-customize-search-field')
?.classList.remove('visible');
clearField();
}
}, [isOpened]);

useEffect(() => {
if (search === '') {
if (customizerPanels?.classList.contains('search-not-found')) {
Expand Down Expand Up @@ -217,15 +197,12 @@ const SearchComponent: React.FC<SearchComponentProps> = ({
return (
<>
<span className="accordion-section">
<span className="search-input">
{__('Search', 'neve') +
' ' +
__('Settings', 'neve').toLowerCase()}
</span>
<span className="nv-search-wrap">
<input
type="text"
placeholder={__('Search', 'neve')}
placeholder={
__('Search', 'neve') + ' ' + __('Settings', 'neve')
}
id="nv-customizer-search-input"
className="nv-customizer-search-input"
value={search}
Expand Down
37 changes: 0 additions & 37 deletions assets/apps/customizer-controls/src/customizer-search/SearchToggle.tsx
View file
Open in desktop

This file was deleted.

22 changes: 2 additions & 20 deletions assets/apps/customizer-controls/src/scss/_customizer-search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,10 @@
#neve-customize-search {
position: absolute;
top: 40px;
right: 0;
width: 40px;
height: 28px;
overflow: hidden;
z-index: 1000;

button {
text-decoration: none;
&:focus:not(:disabled) {
box-shadow: none;
outline: none;
}
}
display: none;
}


#neve-customize-search-field {
display: none;
&.visible {
display: block;
}
display: block;

.accordion-section {
background-color: #fff;
Expand All @@ -37,7 +20,6 @@
.nv-search-wrap {
display: flex;
align-items: center;
margin-top: 6px;
}

.nv-customizer-search-input {
Expand Down
Loading