Skip to content

Conversation

@NicolasMassart
Copy link
Member

  • update broken link to ubount as repos was renamed
  • update submodule

REMAINING QUESTION

The https://github.com/unbound-tech/encryption-ub.git disappeared too. The following line may need to be updated, but I can't find with what.

(jar available at `com.github.unbound-tech:encryption-ub:<version>`)

Note the link is broken in https://github.com/unbound-tech/unbound-integration/tree/master/tessera#create-the-unbound-encryption-jar-file too.

update submodule
@NicolasMassart NicolasMassart marked this pull request as draft February 26, 2021 07:16
@NicolasMassart NicolasMassart self-assigned this Feb 26, 2021
@chris-j-h
Copy link
Contributor

Are there any checks (vale, etc.) that can be added to check for broken links so we're made aware of when things like this happen?

@NicolasMassart
Copy link
Member Author

NicolasMassart commented Feb 26, 2021

Are there any checks (vale, etc.) that can be added to check for broken links so we're made aware of when things like this happen?

This is how I noticed it. I had a nightly build alert for this link. But the other part about com.github.unbound-tech:encryption-ub:<version> not being a link was not noticed. I just looked at it manually.

@chris-j-h
Copy link
Contributor

chris-j-h commented Feb 26, 2021

com.github.unbound-tech:encryption-ub:<version> is a sonatype/maven central artifact name - https://search.maven.org/artifact/com.github.unbound-tech/encryption-ub

@chris-j-h
Copy link
Contributor

Also submitted PR to update unbound's docs unboundsecurity/unbound-integration#6

@NicolasMassart
Copy link
Member Author

com.github.unbound-tech:encryption-ub:<version> is a sonatype/maven central artifact name - https://search.maven.org/artifact/com.github.unbound-tech/encryption-ub

Will the artifact name change given the repos changed?

@NicolasMassart NicolasMassart marked this pull request as ready for review February 26, 2021 11:09
@NicolasMassart NicolasMassart merged commit ced96fd into master Feb 26, 2021
@chris-j-h
Copy link
Contributor

Unbound would have to decide that at release time

@NicolasMassart NicolasMassart deleted the fix-link branch July 27, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants