Skip to content

Conversation

@alinetskyi
Copy link
Contributor

@alinetskyi alinetskyi commented Jun 11, 2025

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@alinetskyi alinetskyi self-assigned this Jun 11, 2025
@alinetskyi alinetskyi requested a review from a team as a code owner June 11, 2025 10:40
@alinetskyi alinetskyi requested review from TxCorpi0x, masihyeganeh, miladz68 and ysv and removed request for a team June 11, 2025 10:40
@alinetskyi alinetskyi force-pushed the finalise_docs_autodeploy branch from 83bbff9 to 0615009 Compare June 11, 2025 10:42
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.65%. Comparing base (e97b6aa) to head (0615009).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   63.61%   61.65%   -1.97%     
==========================================
  Files         161      161              
  Lines       18493    18493              
==========================================
- Hits        11765    11401     -364     
- Misses       5581     5960     +379     
+ Partials     1147     1132      -15     
Flag Coverage Δ
coreum 58.17% <ø> (ø)
coreum-integration-tests-modules 46.19% <ø> (-6.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @TxCorpi0x)


docs/api.md line 6560 at r1 (raw file):

<a name="cosmos.auth.v1beta1.Query"></a>

### Query

just FYI
This file is auto-generated so it shouldn't be edited manually

And most of typos come from cosmos-sdk comments/protobufs
That is why we have that many typos which we can't fix


.typos.yaml line 1 at r1 (raw file):

[default.extend-words]

it is already present in crust but with slightly different config.
Let us know if you want to change config for it - https://github.com/CoreumFoundation/crust/blob/master/build/lint/typos.toml

@alinetskyi alinetskyi force-pushed the finalise_docs_autodeploy branch from 0615009 to cc8e178 Compare July 10, 2025 11:29
@alinetskyi alinetskyi force-pushed the finalise_docs_autodeploy branch 7 times, most recently from c2a8545 to 43b6653 Compare July 10, 2025 11:55
@alinetskyi alinetskyi force-pushed the finalise_docs_autodeploy branch from 43b6653 to fdbc430 Compare July 10, 2025 11:57
@alinetskyi alinetskyi closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants