Skip to content

Conversation

@brandnholl
Copy link
Contributor

@brandnholl brandnholl commented Jul 16, 2023

πŸ€– Generated by Copilot at 926c229

Summary

πŸ“ŠπŸ› οΈπŸ†™

This pull request adds a new feature to the app that lets the user view and edit their grades. It creates new components, pages, and routes for the grades page, the grade details page, and the grade settings section. It also updates a dependency and fixes a formatting issue.

Gradespage components
Show and edit grades with ease
Autumn of learning

Walkthrough

  • Add new pages and components for displaying and editing grade information (link, link, link)
  • Add new option to navigation menu for accessing grades page (link, link)
  • Add new feature to settings page for customizing grade visibility (link)
  • Update dependency version for sharp package (link)
  • Remove empty line from components/settings/index.tsx file (link)

@vercel
Copy link

vercel bot commented Jul 16, 2023

@brandnholl is attempting to deploy a commit to the Coursify Studios Team on Vercel.

To accomplish this, @brandnholl needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@brandnholl brandnholl added this to the MVP milestone Jul 16, 2023
@brandnholl brandnholl marked this pull request as ready for review July 18, 2023 05:45
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
coursify βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 26, 2023 7:25am

@brandnholl
Copy link
Contributor Author

This merge is awaiting the actual setup of grading and interactivity by @IllGive . Ideally we don't want it to fall too behind from dev though.

@IllGive
Copy link
Contributor

IllGive commented Jul 18, 2023

This merge is awaiting the actual setup of grading and interactivity by @IllGive . Ideally we don't want it to fall too behind from dev though.

sounds good

@IllGive IllGive added the feature adding a brand new feature label Jul 18, 2023
IllGive added 2 commits July 18, 2023 21:35
Note that it might not work. I have not tested it yet. Not that I can, there are exactly zero graded submissions right now, and that IS my problem, but I'm too lazy to fix that right now. I must shower, so see you after then.
something is borked.
also disabled/changed some stuff because of changes to db types
@IllGive
Copy link
Contributor

IllGive commented Jul 26, 2023

This merge is awaiting the actual setup of grading and interactivity by @IllGive . Ideally we don't want it to fall too behind from dev though.

sounds good

sorry about this, but if we want this implemented, someone is going to have to take over from me for the next 2 weeks

referencedColumns: ["test"];
},
];
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc these tables have since been deleted

return await Promise.all([
supabase
.from("submissions")
//no need to fetch user_id when we have rls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhhh

setGrade(
data.data.class_users.find((v) => v.user_id == user.id)?.grade
//data.data.class_users.find((v) => v.user_id == user.id)?.grade
100 //TODO: fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

<div className="w-full">
<div className="w-full rounded-lg bg-gray-200 p-4 flex items-center justify-between">
<div>
<h1 className="font-bold text-4xl">Honors Biology</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be hardcoding classes

@Bloxs
Copy link
Contributor

Bloxs commented Sep 24, 2023

also has merge conflicts needing to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature adding a brand new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants