Skip to content

Conversation

@brandnholl
Copy link
Contributor

@brandnholl brandnholl commented Sep 10, 2023

Overview of PR

Written 📝

Standards

All need to be completed before marking a pr as ready to review

  • I have reviewed my code and confirmed it doesn't cause any major security issues or create unhandled edge cases (i.e. unhandled errors)
  • I have tested my code in production and verified that it works as intended
  • I have organized my code based on our brief style guide and made sure that it's rationally componentized
  • I have confirmed the pages I edited work on light and dark mode

Brief Summary

We have a privacy policy now

Tabulated Changes

  • privacy policy

Details

Generated by AI

Walkthrough

🤖 Generated by Copilot at 8066664

  • Exclude privacy path from middleware matcher to avoid interfering with privacy policy page rendering (link)

Poem

🤖 Generated by Copilot at 8066664

config excludes
privacy from middleware
autumn leaves fall fast

AI Summary

🤖 Generated by Copilot at 8066664

Updated config value in middleware.ts to fix privacy policy page rendering. Excluded privacy path from middleware matcher to avoid conflicts with the new page location.

Co-authored-by: Bloxs <[email protected]>
Co-authored-by: Bill Smtih <[email protected]>
Co-authored-by: Lukas <[email protected]>
@brandnholl brandnholl linked an issue Sep 10, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Sep 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coursify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2023 6:18am

Copy link
Contributor

@quick007 quick007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some text on the login page that says "By logging in, you agree to our privacy policy"

<strong className="dark:text-white">
Do we receive any information from third parties?
</strong>{" "}
We do not receive any information from third parties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False, we recive info from their school and google

law, we process the following categories of sensitive information:
</p>
<ul>
<li>student data</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like theres supposed to be more here...

We may use cookies and similar tracking technologies (like web beacons
and pixels) to access or store information. Specific information about
how we use such technologies and how you can refuse certain cookies is
set out in our Cookie Notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should just throw that in here since we don't need to (and don't have) a cookie policy

</p>
<p>
If you have questions or comments about your privacy rights, you may
email us at [email protected].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to put the temp support email here so it doesn't just go into a black hole

Comment on lines +753 to +760
<p>Category A - As long as the user has an account with us</p>
</li>
<li>
<p>Category B - As long as the user has an account with us</p>
</li>
<li>
<p>Category J - As long as the user has an account with us</p>
</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhhh

Comment on lines +982 to +983
Data Protection Officer (DPO), Brandon Holland, by email at
[email protected].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use the temp support email please

Copy link
Contributor

@quick007 quick007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait I meant to request changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy Policy/TOS

3 participants