Skip to content

Conversation

@AlexMooney
Copy link
Contributor

What does this PR do?

Remove the dependency on the uuidtools gem in favor of a couple of lines of plain old Ruby.

In #2216:

since uuidtools has not been updated in 5 years. It seems most likely the fix would be using something from Ruby's standard library to replace the functionality.

Additional Notes

It seems that the only use for this gem is validating UUID input.

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.
    • No need
  • This PR does not rely on API client schema changes.
    • The CI should be fully passing. TBD!
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.
    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@AlexMooney AlexMooney requested review from a team as code owners April 4, 2025 20:38
@buraizu buraizu self-assigned this Apr 4, 2025
Copy link

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed

@jack-edmonds-dd
Copy link
Contributor

Looks good to me. I ran the tests in #2345 (external contributions don't have access to the runner secrets to execute most of the tests).

@jack-edmonds-dd jack-edmonds-dd merged commit 2d8705f into DataDog:master Apr 17, 2025
15 of 17 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants