Skip to content

INA-7297: Update incident type test attributes so BDD tests use random hash for incident type name #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

INA-7297: Update incident type test attributes so BDD tests use random hash for incident type name #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-11 12:58:58.679153",
"spec_repo_commit": "7307da21"
"regenerated": "2025-04-11 15:22:52.291731",
"spec_repo_commit": "b50db944"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-11 12:58:58.695743",
"spec_repo_commit": "7307da21"
"regenerated": "2025-04-11 15:22:52.308333",
"spec_repo_commit": "b50db944"
}
}
}
2 changes: 1 addition & 1 deletion cassettes/features/v2/incidents/Create-an-incident-type-returns-CREATED-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2024-11-04T19:02:20.402Z
2025-04-09T20:37:29.894Z
14 changes: 6 additions & 8 deletions cassettes/features/v2/incidents/Create-an-incident-type-returns-CREATED-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cassettes/features/v2/incidents/Delete-an-incident-type-returns-OK-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2024-11-04T19:02:22.569Z
2025-04-09T20:37:30.425Z
28 changes: 14 additions & 14 deletions cassettes/features/v2/incidents/Delete-an-incident-type-returns-OK-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cassettes/features/v2/incidents/Update-an-incident-type-returns-OK-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2024-11-04T19:02:38.662Z
2025-04-09T20:37:30.806Z
25 changes: 11 additions & 14 deletions cassettes/features/v2/incidents/Update-an-incident-type-returns-OK-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/v2/incidents/CreateIncidentType.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
attributes: DatadogAPIClient::V2::IncidentTypeAttributes.new({
description: "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.",
is_default: false,
name: "Security Incident",
name: "8d4bbb66dccf2456",
}),
type: DatadogAPIClient::V2::IncidentTypeType::INCIDENT_TYPES,
}),
Expand Down
2 changes: 1 addition & 1 deletion features/v2/given.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
"parameters": [
{
"name": "body",
"value": "{\n \"data\": {\n \"attributes\": {\n \"name\": \"Security Incident\",\n \"description\": \"Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.\",\n \"is_default\": false\n },\n \"type\": \"incident_types\"\n }\n}"
"value": "{\n \"data\": {\n \"attributes\": {\n \"name\": \"{{ unique_hash }}\",\n \"description\": \"Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.\",\n \"is_default\": false\n },\n \"type\": \"incident_types\"\n }\n}"
}
],
"step": "there is a valid \"incident_type\" in the system",
Expand Down
2 changes: 1 addition & 1 deletion features/v2/incidents.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Feature: Incidents
Scenario: Create an incident type returns "CREATED" response
Given operation "CreateIncidentType" enabled
And new "CreateIncidentType" request
And body with value {"data": {"attributes": {"description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.", "is_default": false, "name": "Security Incident"}, "type": "incident_types"}}
And body with value {"data": {"attributes": {"description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.", "is_default": false, "name": "{{ unique_hash }}"}, "type": "incident_types"}}
When the request is sent
Then the response status is 201 CREATED

Expand Down
Loading