Support filtering shared class-info by arbitrary predicates #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, filtering by class-loader sub-graphs.
mcculls
commented
Oct 7, 2025
| * @see ClassLoaderIndex#getClassLoaderKeyId(ClassLoader) | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public T find(CharSequence className, IntPredicate classLoaderKeyFilter) { |
Collaborator
Author
There was a problem hiding this comment.
Note this is structurally very similar to the other find method, but I don't want to deduplicate the code for performance reasons. The other method uses a fast primitive operator inside the loop, whereas this involves a method call.
There was a problem hiding this comment.
Might be worth leaving a text comment here, for anyone opening this source file, and not having the PR context :)
cecile75
approved these changes
Oct 7, 2025
For my own understanding. How does this work with classloader subgraphs ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, filtering by class-loader sub-graphs - this will be useful in environments such as OSGi