- 
                Notifications
    You must be signed in to change notification settings 
- Fork 160
RUM-8042 Batch Blocked telemetry with generic aggregation #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
229b5b9    to
    09a608a      
    Compare
  
    | Datadog ReportBranch report:  ✅ 0 Failed, 2423 Passed, 1485 Skipped, 3m 5.28s Total duration (1m 11.75s time saved) | 
09a608a    to
    f51cb4c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
        5204914
      
    aa1b8d9    to
    31ae520      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small questions, otherwise LGMT!
31ae520    to
    564152b      
    Compare
  
    de4fe5a    to
    0b556f7      
    Compare
  
    cd68fed    to
    04e471b      
    Compare
  
    4f1d95b    to
    2cab83e      
    Compare
  
    5d65982    to
    6dc667f      
    Compare
  
    6dc667f    to
    f4df695      
    Compare
  
    
What and why?
Introduce a new telemetry metric for tracking batch upload issues. It replaces the previous "Upload Quality" telemetry with a more specific "Batch Blocked" metric that provides better visibility into upload failures. This change provides a telemetry format more suitable for graphing.
More context in RFC (internal)
How?
The implementation uses a generic metric telemetry aggregation to collect metric and report them when the application is pushed to background:
1. Metric Types:
2. Metrics:
batch_blocked: Tracks the number of times batch uploads are blockedpending_batches: Tracks the number of batches waiting to be uploadedupload_cycle: Monitors count of upload cycleEach metric supports configurable cardinalities for detailed analysis
4. Architecture:
Review checklist
make api-surface)