-
Notifications
You must be signed in to change notification settings - Fork 151
[Debugger-Test Optimization] Add agent-less support to ER #7859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7859 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 | 2.054 | 853,429.64 | 415,460.94 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 396μs | 119ns | 460ns | 0 | 0 | 0 | 4.55 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 809μs | 13.4μs | 134μs | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 430μs | 84.7ns | 328ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 289μs | 22.3ns | 83.3ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 671μs | 13.5μs | 134μs | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 310μs | 37.6ns | 146ns | 0 | 0 | 0 | 2.29 KB |
| #7859 | RunWafRealisticBenchmark |
net6.0 | 396μs | 84.8ns | 294ns | 0 | 0 | 0 | 4.55 KB |
| #7859 | RunWafRealisticBenchmark |
netcoreapp3.1 | 415μs | 910ns | 3.41μs | 0 | 0 | 0 | 4.48 KB |
| #7859 | RunWafRealisticBenchmark |
net472 | 434μs | 92.6ns | 346ns | 0 | 0 | 0 | 4.66 KB |
| #7859 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 289μs | 72.2ns | 280ns | 0 | 0 | 0 | 2.24 KB |
| #7859 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 725μs | 5.94μs | 59.4μs | 0 | 0 | 0 | 2.22 KB |
| #7859 | RunWafRealisticBenchmarkWithAttack |
net472 | 311μs | 42.2ns | 163ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 61.3μs | 41.5ns | 161ns | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 71.6μs | 63.2ns | 245ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.00307ns | 0.00157ns | 0.00609ns | 0 | 0 | 0 | 0 b |
| #7859 | SendRequest |
net6.0 | 61.2μs | 106ns | 383ns | 0 | 0 | 0 | 14.52 KB |
| #7859 | SendRequest |
netcoreapp3.1 | 73.2μs | 314ns | 1.4μs | 0 | 0 | 0 | 17.42 KB |
| #7859 | SendRequest |
net472 | 0.00282ns | 0.00122ns | 0.00472ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7859
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472
0 b
85 B
85 B
∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472
0 b
47 B
47 B
∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1
1 B
19 B
18 B
1,800.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
2 B
6 B
4 B
200.00%
Fewer allocations 🎉 in #7859
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0
7 B
4 B
-3 B
-42.86%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 | 0 b | 85 B | 85 B | ∞ |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 | 0 b | 47 B | 47 B | ∞ |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 | 1 B | 19 B | 18 B | 1,800.00% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 2 B | 6 B | 4 B | 200.00% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 7 B | 4 B | -3 B | -42.86% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.91ms | 532ns | 1.99μs | 0 | 0 | 0 | 640.01 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.14ms | 7.49μs | 29μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.62ms | 881ns | 3.41μs | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.35ms | 2.73μs | 10.6μs | 0 | 0 | 0 | 7 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.69ms | 297ns | 1.15μs | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 1.94ms | 170ns | 638ns | 0 | 0 | 0 | 0 b |
| master | OptimizedCharSliceWithPool |
net6.0 | 816μs | 26.3ns | 102ns | 0 | 0 | 0 | 2 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 873μs | 52.2ns | 195ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSliceWithPool |
net472 | 1.14ms | 113ns | 439ns | 0 | 0 | 0 | 0 b |
| #7859 | OriginalCharSlice |
net6.0 | 1.91ms | 284ns | 1.1μs | 0 | 0 | 0 | 640.01 KB |
| #7859 | OriginalCharSlice |
netcoreapp3.1 | 2.12ms | 2.41μs | 9.35μs | 0 | 0 | 0 | 640 KB |
| #7859 | OriginalCharSlice |
net472 | 2.77ms | 1.81μs | 7μs | 100 | 0 | 0 | 641.95 KB |
| #7859 | OptimizedCharSlice |
net6.0 | 1.45ms | 378ns | 1.46μs | 0 | 0 | 0 | 4 B |
| #7859 | OptimizedCharSlice |
netcoreapp3.1 | 1.68ms | 498ns | 1.93μs | 0 | 0 | 0 | 1 B |
| #7859 | OptimizedCharSlice |
net472 | 2.08ms | 9.25μs | 35.8μs | 0 | 0 | 0 | 85 B |
| #7859 | OptimizedCharSliceWithPool |
net6.0 | 836μs | 68.1ns | 264ns | 0 | 0 | 0 | 6 B |
| #7859 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 812μs | 273ns | 1.06μs | 0 | 0 | 0 | 19 B |
| #7859 | OptimizedCharSliceWithPool |
net472 | 1.15ms | 143ns | 554ns | 0 | 0 | 0 | 47 B |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7859
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
55.94 KB
57.13 KB
1.19 KB
2.13%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
41.78 KB
42.6 KB
817 B
1.96%
Fewer allocations 🎉 in #7859
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1
42.75 KB
41.85 KB
-897 B
-2.10%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 55.94 KB | 57.13 KB | 1.19 KB | 2.13% |
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.78 KB | 42.6 KB | 817 B | 1.96% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 42.75 KB | 41.85 KB | -897 B | -2.10% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 719μs | 937ns | 3.51μs | 0 | 0 | 0 | 41.78 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 748μs | 2.2μs | 8.54μs | 0 | 0 | 0 | 42.75 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.03ms | 5.08μs | 21.6μs | 5.21 | 0 | 0 | 55.94 KB |
| #7859 | WriteAndFlushEnrichedTraces |
net6.0 | 694μs | 2.46μs | 9.54μs | 0 | 0 | 0 | 42.6 KB |
| #7859 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 799μs | 4.57μs | 32.9μs | 0 | 0 | 0 | 41.85 KB |
| #7859 | WriteAndFlushEnrichedTraces |
net472 | 1.01ms | 4.77μs | 19.7μs | 8.93 | 0 | 0 | 57.13 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.89μs | 9.71ns | 47.6ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.62μs | 9.75ns | 37.8ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.86μs | 3.4ns | 13.2ns | 0.156 | 0.0142 | 0 | 987 B |
| #7859 | ExecuteNonQuery |
net6.0 | 1.98μs | 1.25ns | 4.83ns | 0 | 0 | 0 | 1.02 KB |
| #7859 | ExecuteNonQuery |
netcoreapp3.1 | 2.63μs | 9.32ns | 36.1ns | 0 | 0 | 0 | 1.02 KB |
| #7859 | ExecuteNonQuery |
net472 | 2.81μs | 2.76ns | 10.7ns | 0.156 | 0.0141 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.7μs | 7.41ns | 27.7ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.23μs | 7.38ns | 26.6ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.56μs | 3.18ns | 12.3ns | 0.161 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.8μs | 1.26ns | 4.56ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.32μs | 11.2ns | 46.2ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.84μs | 4.65ns | 18ns | 0.173 | 0 | 0 | 1.1 KB |
| #7859 | CallElasticsearch |
net6.0 | 1.73μs | 6.91ns | 26.8ns | 0 | 0 | 0 | 1.03 KB |
| #7859 | CallElasticsearch |
netcoreapp3.1 | 2.26μs | 10.8ns | 41.8ns | 0 | 0 | 0 | 1.03 KB |
| #7859 | CallElasticsearch |
net472 | 3.53μs | 6.3ns | 24.4ns | 0.16 | 0 | 0 | 1.04 KB |
| #7859 | CallElasticsearchAsync |
net6.0 | 1.81μs | 4.12ns | 16ns | 0 | 0 | 0 | 1.01 KB |
| #7859 | CallElasticsearchAsync |
netcoreapp3.1 | 2.38μs | 9.08ns | 35.2ns | 0 | 0 | 0 | 1.08 KB |
| #7859 | CallElasticsearchAsync |
net472 | 3.69μs | 3.6ns | 13ns | 0.167 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.85μs | 5.4ns | 20.9ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.5μs | 3.77ns | 14.6ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.52μs | 0.907ns | 3.51ns | 0.138 | 0 | 0 | 915 B |
| #7859 | ExecuteAsync |
net6.0 | 1.83μs | 8.53ns | 34.1ns | 0 | 0 | 0 | 952 B |
| #7859 | ExecuteAsync |
netcoreapp3.1 | 2.55μs | 7.44ns | 28.8ns | 0 | 0 | 0 | 952 B |
| #7859 | ExecuteAsync |
net472 | 2.63μs | 3.25ns | 12.6ns | 0.144 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 7μs | 4.77ns | 17.8ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 9.15μs | 26.8ns | 104ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12μs | 6.39ns | 23.9ns | 0.481 | 0 | 0 | 3.18 KB |
| #7859 | SendAsync |
net6.0 | 6.95μs | 30.3ns | 117ns | 0 | 0 | 0 | 2.36 KB |
| #7859 | SendAsync |
netcoreapp3.1 | 8.87μs | 14.9ns | 57.8ns | 0 | 0 | 0 | 2.9 KB |
| #7859 | SendAsync |
net472 | 12μs | 8.01ns | 31ns | 0.478 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7859
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
258.88 KB
277.74 KB
18.86 KB
7.28%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
258.66 KB
276.04 KB
17.38 KB
6.72%
Fewer allocations 🎉 in #7859
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0
43.44 KB
43.2 KB
-240 B
-0.55%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1
43.19 KB
42.94 KB
-248 B
-0.57%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472
65.54 KB
57.34 KB
-8.19 KB
-12.50%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 258.88 KB | 277.74 KB | 18.86 KB | 7.28% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 258.66 KB | 276.04 KB | 17.38 KB | 6.72% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 43.44 KB | 43.2 KB | -240 B | -0.55% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 43.19 KB | 42.94 KB | -248 B | -0.57% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 65.54 KB | 57.34 KB | -8.19 KB | -12.50% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 45.5μs | 252ns | 2.09μs | 0 | 0 | 0 | 43.44 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 50μs | 290ns | 2.28μs | 0 | 0 | 0 | 43.19 KB |
| master | StringConcatBenchmark |
net472 | 58.2μs | 169ns | 632ns | 0 | 0 | 0 | 65.54 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 459μs | 1.55μs | 6.22μs | 0 | 0 | 0 | 258.88 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 523μs | 2.54μs | 10.8μs | 0 | 0 | 0 | 258.66 KB |
| master | StringConcatAspectBenchmark |
net472 | 411μs | 2.07μs | 10.5μs | 0 | 0 | 0 | 278.53 KB |
| #7859 | StringConcatBenchmark |
net6.0 | 44.3μs | 227ns | 990ns | 0 | 0 | 0 | 43.2 KB |
| #7859 | StringConcatBenchmark |
netcoreapp3.1 | 49.5μs | 262ns | 2.03μs | 0 | 0 | 0 | 42.94 KB |
| #7859 | StringConcatBenchmark |
net472 | 56.8μs | 290ns | 1.3μs | 0 | 0 | 0 | 57.34 KB |
| #7859 | StringConcatAspectBenchmark |
net6.0 | 500μs | 2μs | 7.2μs | 0 | 0 | 0 | 277.74 KB |
| #7859 | StringConcatAspectBenchmark |
netcoreapp3.1 | 524μs | 2μs | 7.22μs | 0 | 0 | 0 | 276.04 KB |
| #7859 | StringConcatAspectBenchmark |
net472 | 406μs | 2.15μs | 11μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.67μs | 13.7ns | 61.1ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.58μs | 9.86ns | 38.2ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
net472 | 3.97μs | 3.72ns | 14.4ns | 0.257 | 0 | 0 | 1.64 KB |
| #7859 | EnrichedLog |
net6.0 | 2.57μs | 13.8ns | 78ns | 0 | 0 | 0 | 1.7 KB |
| #7859 | EnrichedLog |
netcoreapp3.1 | 3.59μs | 8.62ns | 33.4ns | 0 | 0 | 0 | 1.7 KB |
| #7859 | EnrichedLog |
net472 | 3.94μs | 3.87ns | 15ns | 0.256 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 122μs | 72.1ns | 260ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 128μs | 72.6ns | 262ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 166μs | 232ns | 897ns | 0 | 0 | 0 | 4.52 KB |
| #7859 | EnrichedLog |
net6.0 | 123μs | 127ns | 491ns | 0 | 0 | 0 | 4.31 KB |
| #7859 | EnrichedLog |
netcoreapp3.1 | 128μs | 326ns | 1.18μs | 0 | 0 | 0 | 4.31 KB |
| #7859 | EnrichedLog |
net472 | 165μs | 81.4ns | 294ns | 0 | 0 | 0 | 4.51 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 5μs | 23.5ns | 97ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.9μs | 28.4ns | 110ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.58μs | 4.68ns | 17.5ns | 0.301 | 0 | 0 | 2.08 KB |
| #7859 | EnrichedLog |
net6.0 | 4.92μs | 17.4ns | 60.3ns | 0 | 0 | 0 | 2.26 KB |
| #7859 | EnrichedLog |
netcoreapp3.1 | 7.11μs | 28.2ns | 109ns | 0 | 0 | 0 | 2.26 KB |
| #7859 | EnrichedLog |
net472 | 7.57μs | 15.4ns | 59.8ns | 0.305 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 2.01μs | 1.23ns | 4.61ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.52μs | 12ns | 48.2ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.19μs | 5.06ns | 19.6ns | 0.189 | 0 | 0 | 1.2 KB |
| #7859 | SendReceive |
net6.0 | 1.91μs | 9.47ns | 40.2ns | 0 | 0 | 0 | 1.2 KB |
| #7859 | SendReceive |
netcoreapp3.1 | 2.6μs | 12.3ns | 52.3ns | 0 | 0 | 0 | 1.2 KB |
| #7859 | SendReceive |
net472 | 3.14μs | 2.57ns | 9.95ns | 0.188 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.31μs | 13.3ns | 49.9ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.59μs | 5.7ns | 22.1ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.92μs | 6.43ns | 24.1ns | 0.311 | 0 | 0 | 2.03 KB |
| #7859 | EnrichedLog |
net6.0 | 4.42μs | 4.78ns | 18.5ns | 0 | 0 | 0 | 1.58 KB |
| #7859 | EnrichedLog |
netcoreapp3.1 | 5.51μs | 19.8ns | 76.7ns | 0 | 0 | 0 | 1.63 KB |
| #7859 | EnrichedLog |
net472 | 6.58μs | 3.84ns | 13.9ns | 0.293 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 788ns | 4.15ns | 20.3ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 973ns | 4.79ns | 19.7ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 942ns | 0.772ns | 2.99ns | 0.09 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 930ns | 4.96ns | 24.8ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.17μs | 6.38ns | 36.1ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 1.18μs | 0.919ns | 3.44ns | 0.1 | 0 | 0 | 658 B |
| #7859 | StartFinishSpan |
net6.0 | 785ns | 3.32ns | 13.7ns | 0 | 0 | 0 | 576 B |
| #7859 | StartFinishSpan |
netcoreapp3.1 | 954ns | 5.15ns | 28.6ns | 0 | 0 | 0 | 576 B |
| #7859 | StartFinishSpan |
net472 | 959ns | 0.168ns | 0.605ns | 0.0914 | 0 | 0 | 578 B |
| #7859 | StartFinishScope |
net6.0 | 920ns | 4.66ns | 21.9ns | 0 | 0 | 0 | 696 B |
| #7859 | StartFinishScope |
netcoreapp3.1 | 1.2μs | 3.04ns | 11.8ns | 0 | 0 | 0 | 696 B |
| #7859 | StartFinishScope |
net472 | 1.16μs | 0.452ns | 1.75ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.08μs | 5.6ns | 22.4ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.49μs | 5.97ns | 23.1ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.45μs | 0.655ns | 2.45ns | 0.102 | 0 | 0 | 658 B |
| #7859 | RunOnMethodBegin |
net6.0 | 1.09μs | 5.86ns | 31ns | 0 | 0 | 0 | 696 B |
| #7859 | RunOnMethodBegin |
netcoreapp3.1 | 1.46μs | 2.78ns | 10.8ns | 0 | 0 | 0 | 696 B |
| #7859 | RunOnMethodBegin |
net472 | 1.43μs | 0.458ns | 1.71ns | 0.1 | 0 | 0 | 658 B |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7859) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (76ms) : 69, 83
master - mean (75ms) : 70, 80
section Bailout
This PR (7859) - mean (83ms) : 75, 91
master - mean (79ms) : 74, 83
section CallTarget+Inlining+NGEN
This PR (7859) - mean (1,080ms) : 989, 1172
master - mean (1,067ms) : 986, 1147
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (121ms) : 110, 133
master - mean (118ms) : 110, 126
section Bailout
This PR (7859) - mean (121ms) : 114, 128
master - mean (120ms) : 112, 129
section CallTarget+Inlining+NGEN
This PR (7859) - mean (771ms) : 716, 825
master - mean (760ms) : 719, 800
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (106ms) : 99, 113
master - mean (105ms) : 99, 110
section Bailout
This PR (7859) - mean (110ms) : 100, 120
master - mean (106ms) : 101, 112
section CallTarget+Inlining+NGEN
This PR (7859) - mean (724ms) : 670, 778
master - mean (713ms) : 668, 758
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (106ms) : 96, 115
master - mean (105ms) : 97, 113
section Bailout
This PR (7859) - mean (108ms) : 98, 118
master - mean (106ms) : 101, 111
section CallTarget+Inlining+NGEN
This PR (7859) - mean (691ms) : 655, 727
master - mean (688ms) : 660, 716
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (201ms) : 193, 210
master - mean (193ms) : 189, 197
section Bailout
This PR (7859) - mean (199ms) : 194, 204
master - mean (196ms) : 193, 199
section CallTarget+Inlining+NGEN
This PR (7859) - mean (1,137ms) : 1049, 1226
master - mean (1,115ms) : 1045, 1185
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (285ms) : 274, 297
master - mean (276ms) : 272, 281
section Bailout
This PR (7859) - mean (283ms) : 273, 293
master - mean (277ms) : 274, 280
section CallTarget+Inlining+NGEN
This PR (7859) - mean (926ms) : 877, 974
master - mean (903ms) : 851, 955
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (275ms) : 267, 282
master - mean (270ms) : 264, 276
section Bailout
This PR (7859) - mean (275ms) : 270, 280
master - mean (268ms) : 265, 272
section CallTarget+Inlining+NGEN
This PR (7859) - mean (899ms) : 857, 941
master - mean (893ms) : 833, 953
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7859) - mean (271ms) : 265, 277
master - mean (270ms) : 265, 274
section Bailout
This PR (7859) - mean (270ms) : 266, 275
master - mean (269ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (7859) - mean (831ms) : 807, 855
master - mean (835ms) : 808, 862
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
SnapshotUploadApi/ExceptionReplayto use static debugger intakes when the agent is absent.Reason for change
For complete Test Optimization + Exception Replay integration in environments without the Datadog Agent need a documented path to send snapshots directly to Datadog without impacting Shared Debugger/DI behaviors. The plan isolates ER agentless support, reusing
DD_API_KEY/DD_SITE, and ensures we do not silently initialize features (symbol uploads) that still require the agent/RCM.Implementation details
ConfigurationKeys.Debugger+ExceptionReplaySettingsnow surfaceDD_EXCEPTION_REPLAY_AGENTLESS_ENABLED/DD_EXCEPTION_REPLAY_AGENTLESS_URL, defaulting todatadoghq.comand the existingDD_API_KEY.ExceptionReplayTransportFactorycreates either the existing agent transport or an HTTPS transport that injectsDD-API-KEY,DD-EVP-ORIGIN=dd-trace-dotnet, and a per-requestDD-REQUEST-ID, honouring site overrides.SnapshotUploadApiaccepts a static endpoint so ER can bypass discovery when agentless, andExceptionReplaywires the new transport info throughDebuggerUploadApiFactory.DebuggerManagernow emits a clear log and skips symbol uploader initialization whenever ER is agentless, avoiding futile RCM attempts.Test coverage
SnapshotUploadApiTests) continue to validate static endpoint behavior.Other details