-
Notifications
You must be signed in to change notification settings - Fork 151
[Azure Functions] Fix Azure Functions NuGet script for Linux and macOS #7864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Functions] Fix Azure Functions NuGet script for Linux and macOS #7864
Conversation
11f06a5 to
082632a
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7864) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (78ms) : 70, 87
master - mean (77ms) : 71, 84
section Bailout
This PR (7864) - mean (82ms) : 74, 91
master - mean (80ms) : 75, 85
section CallTarget+Inlining+NGEN
This PR (7864) - mean (1,104ms) : 1015, 1193
master - mean (1,080ms) : 989, 1172
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (121ms) : 109, 132
master - mean (119ms) : 109, 129
section Bailout
This PR (7864) - mean (122ms) : 114, 130
master - mean (122ms) : 113, 131
section CallTarget+Inlining+NGEN
This PR (7864) - mean (785ms) : 731, 840
master - mean (773ms) : 727, 820
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (109ms) : 101, 117
master - mean (109ms) : 98, 119
section Bailout
This PR (7864) - mean (109ms) : 100, 118
master - mean (109ms) : 100, 118
section CallTarget+Inlining+NGEN
This PR (7864) - mean (742ms) : 694, 790
master - mean (727ms) : 686, 769
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (109ms) : 98, 119
master - mean (106ms) : 99, 114
section Bailout
This PR (7864) - mean (107ms) : 97, 116
master - mean (108ms) : 98, 118
section CallTarget+Inlining+NGEN
This PR (7864) - mean (711ms) : 676, 745
master - mean (702ms) : 666, 739
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (195ms) : 189, 200
master - mean (195ms) : 191, 199
section Bailout
This PR (7864) - mean (201ms) : 195, 208
master - mean (200ms) : 196, 204
section CallTarget+Inlining+NGEN
This PR (7864) - mean (1,128ms) : 1051, 1204
master - mean (1,127ms) : 1056, 1197
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (281ms) : 275, 287
master - mean (279ms) : 273, 286
section Bailout
This PR (7864) - mean (280ms) : 275, 286
master - mean (282ms) : 272, 292
section CallTarget+Inlining+NGEN
This PR (7864) - mean (934ms) : 887, 980
master - mean (922ms) : 875, 968
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (275ms) : 267, 283
master - mean (272ms) : 266, 278
section Bailout
This PR (7864) - mean (277ms) : 266, 288
master - mean (272ms) : 269, 274
section CallTarget+Inlining+NGEN
This PR (7864) - mean (904ms) : 855, 953
master - mean (902ms) : 854, 950
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7864) - mean (273ms) : 265, 280
master - mean (272ms) : 265, 278
section Bailout
This PR (7864) - mean (273ms) : 266, 280
master - mean (273ms) : 267, 279
section CallTarget+Inlining+NGEN
This PR (7864) - mean (831ms) : 803, 858
master - mean (831ms) : 806, 856
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Fixed the
Build-AzureFunctionsNuget.ps1script to work on Linux and macOS in addition to Windows.Reason for change
The script only worked on only Windows.
Implementation details
build.ps1for Windows,build.shfor Linux/macOS)Test coverage
Tested manually on Windows and Linux. This script is only used to build local dev versions of the nuget package, not production code.
Other details
n/a