Skip to content

Conversation

@eliottness
Copy link
Contributor

What does this PR do?

Fixes an issue that would trigger body analysis even if we were not capable of parsing said-body.

Motivation

Parse body more ofter because sampling would not trigger on wrong requests

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness requested a review from a team as a code owner November 7, 2025 14:09
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Nov 7, 2025
@eliottness eliottness changed the title fix(appsec): should not run sampler if the content-type cannot be parsed fix(appsec): should not run sampler if the content cannot be parsed Nov 7, 2025
@eliottness
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 7, 2025

View all feedbacks in Devflow UI.

2025-11-07 14:10:20 UTC ℹ️ Start processing command /merge


2025-11-07 14:10:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-07 18:11:11 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@eliottness eliottness removed apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: waiting labels Nov 7, 2025
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Nov 7, 2025
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025

Benchmarks

Benchmark execution time: 2025-11-10 15:24:47

Comparing candidate commit ac83cb0 in PR branch eliottness/api10-better-sampling with baseline commit 1557bbd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics.

Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs appsec mergequeue-status: removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants