Skip to content

Conversation

@bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 17, 2025

Incorporating the merged changes in libdatadog.

@bwoebi bwoebi requested review from a team as code owners October 17, 2025 17:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.76%. Comparing base (50ce39c) to head (c92d9b9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3453      +/-   ##
==========================================
- Coverage   61.90%   61.76%   -0.15%     
==========================================
  Files         142      142              
  Lines       12895    12895              
  Branches     1689     1689              
==========================================
- Hits         7983     7964      -19     
- Misses       4153     4172      +19     
  Partials      759      759              

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ce39c...c92d9b9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-11-04 20:45:28

Comparing candidate commit d62a9cc in PR branch bob/sidecar-crashtracker with baseline commit 50ce39c in branch master.

Found 7 performance improvements and 7 performance regressions! Performance is the same for 178 metrics, 2 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.175µs; +5.645µs] or [+3.002%; +5.336%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+7.640µs; +8.800µs] or [+7.300%; +8.407%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-62.398µs; -58.401µs] or [-23.612%; -22.099%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟩 execution_time [-58.288µs; -54.562µs] or [-22.445%; -21.010%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-57.509µs; -52.967µs] or [-21.973%; -20.238%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟩 execution_time [-57.737µs; -53.056µs] or [-22.276%; -20.470%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟩 execution_time [-305.506µs; -271.430µs] or [-28.821%; -25.606%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟩 execution_time [-283.315µs; -236.619µs] or [-26.124%; -21.818%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+55.026ns; +101.374ns] or [+4.586%; +8.449%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+91.644ns; +163.156ns] or [+7.886%; +14.040%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+100.080ns; +149.320ns] or [+8.584%; +12.807%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+74.089ns; +164.711ns] or [+6.274%; +13.948%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 mem_peak [+1.684MB; +1.693MB] or [+4.074%; +4.097%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-29.441µs; -18.759µs] or [-6.676%; -4.254%]

@bwoebi bwoebi force-pushed the bob/sidecar-crashtracker branch from 44869c3 to 20174dc Compare November 3, 2025 13:38
@bwoebi bwoebi force-pushed the bob/sidecar-crashtracker branch 7 times, most recently from d62a9cc to c92d9b9 Compare November 5, 2025 23:11
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the bob/sidecar-crashtracker branch from c92d9b9 to f2e672d Compare November 5, 2025 23:51
@bwoebi bwoebi merged commit 789048a into master Nov 6, 2025
1509 of 1585 checks passed
@bwoebi bwoebi deleted the bob/sidecar-crashtracker branch November 6, 2025 00:01
@github-actions github-actions bot added this to the 1.14.0 milestone Nov 6, 2025
bwoebi added a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants