-
Notifications
You must be signed in to change notification settings - Fork 474
ci: move circular import detection job from github actions to gitlab #15662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 3 ms. The average import time from base is: 245 ± 6 ms. The import time difference between this PR and base is: 4.1 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Bloop Bleep... Dogbot HereCircular import analysis🚨 New circular imports detected 🚨The following circular imports among modules have been detected on this PR, when compared to the base branch: Please consider refactoring your changes in accordance to the Separation of Concerns principle. |
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questions, I don't think any are blocking really
Performance SLOsComparing candidate emmett.butler/circular-imports-gitlab (31df56f) with baseline main (1dcf5d1) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.026µs (SLO: <20.000µs -9.9%) vs baseline: 📈 +21.5% Memory: ✅ 42.998MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 14.891µs (SLO: <20.000µs 📉 -25.5%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.5% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.551µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.1% ✅ bytearray_aspectTime: ✅ 18.011µs (SLO: <30.000µs 📉 -40.0%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 23.948µs (SLO: <30.000µs 📉 -20.2%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 2.753µs (SLO: <10.000µs 📉 -72.5%) vs baseline: +1.3% Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ bytearray_noaspectTime: ✅ 1.472µs (SLO: <10.000µs 📉 -85.3%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 16.754µs (SLO: <20.000µs 📉 -16.2%) vs baseline: +0.3% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 1.415µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.3% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.0% ✅ bytesio_aspectTime: ✅ 55.744µs (SLO: <70.000µs 📉 -20.4%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 3.284µs (SLO: <10.000µs 📉 -67.2%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.3% ✅ capitalize_aspectTime: ✅ 14.617µs (SLO: <20.000µs 📉 -26.9%) vs baseline: -0.7% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 2.604µs (SLO: <10.000µs 📉 -74.0%) vs baseline: +0.5% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 14.621µs (SLO: <20.000µs 📉 -26.9%) vs baseline: -0.9% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 3.189µs (SLO: <10.000µs 📉 -68.1%) vs baseline: +0.9% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.3% ✅ decode_aspectTime: ✅ 15.793µs (SLO: <30.000µs 📉 -47.4%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.6% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.5% ✅ encode_aspectTime: ✅ 14.886µs (SLO: <30.000µs 📉 -50.4%) vs baseline: -0.5% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 1.650µs (SLO: <10.000µs 📉 -83.5%) vs baseline: +9.7% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.2% ✅ format_aspectTime: ✅ 170.824µs (SLO: <200.000µs 📉 -14.6%) vs baseline: -0.3% Memory: ✅ 43.096MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +4.5% ✅ format_map_aspectTime: ✅ 191.146µs (SLO: <200.000µs -4.4%) vs baseline: +0.3% Memory: ✅ 43.136MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 3.821µs (SLO: <10.000µs 📉 -61.8%) vs baseline: +1.4% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 3.153µs (SLO: <10.000µs 📉 -68.5%) vs baseline: +1.2% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.8% ✅ index_aspectTime: ✅ 15.405µs (SLO: <20.000µs 📉 -23.0%) vs baseline: +0.4% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.465µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.8% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ join_aspectTime: ✅ 16.991µs (SLO: <20.000µs 📉 -15.0%) vs baseline: -0.6% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 1.551µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.2% Memory: ✅ 42.723MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +4.1% ✅ ljust_aspectTime: ✅ 21.033µs (SLO: <30.000µs 📉 -29.9%) vs baseline: +0.8% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 2.700µs (SLO: <10.000µs 📉 -73.0%) vs baseline: -0.4% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.5% ✅ lower_aspectTime: ✅ 21.640µs (SLO: <30.000µs 📉 -27.9%) vs baseline: 📈 +20.8% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 2.460µs (SLO: <10.000µs 📉 -75.4%) vs baseline: +1.7% Memory: ✅ 43.057MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +5.8% ✅ lstrip_aspectTime: ✅ 17.784µs (SLO: <20.000µs 📉 -11.1%) vs baseline: +1.4% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 1.877µs (SLO: <10.000µs 📉 -81.2%) vs baseline: +0.6% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 166.121µs (SLO: <200.000µs 📉 -16.9%) vs baseline: ~same Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.598µs (SLO: <200.000µs 📉 -12.7%) vs baseline: -0.3% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.3% ✅ modulo_aspect_for_bytesTime: ✅ 168.901µs (SLO: <200.000µs 📉 -15.5%) vs baseline: +0.1% Memory: ✅ 43.175MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.968µs (SLO: <200.000µs 📉 -14.0%) vs baseline: ~same Memory: ✅ 43.155MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 3.696µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +1.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.5% ✅ replace_aspectTime: ✅ 211.891µs (SLO: <300.000µs 📉 -29.4%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <44.000MB -2.1%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 2.902µs (SLO: <10.000µs 📉 -71.0%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 1.414µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.523µs (SLO: <10.000µs 📉 -94.8%) vs baseline: ~same Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.4% ✅ rstrip_aspectTime: ✅ 19.143µs (SLO: <30.000µs 📉 -36.2%) vs baseline: +0.4% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 1.956µs (SLO: <10.000µs 📉 -80.4%) vs baseline: +2.1% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.8% ✅ slice_aspectTime: ✅ 19.317µs (SLO: <20.000µs -3.4%) vs baseline: 📈 +21.7% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.8% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.2% ✅ stringio_aspectTime: ✅ 54.141µs (SLO: <80.000µs 📉 -32.3%) vs baseline: -0.4% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 3.677µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.5% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.6% ✅ strip_aspectTime: ✅ 17.796µs (SLO: <20.000µs 📉 -11.0%) vs baseline: +0.7% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 1.878µs (SLO: <10.000µs 📉 -81.2%) vs baseline: +1.2% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.2% ✅ swapcase_aspectTime: ✅ 18.587µs (SLO: <30.000µs 📉 -38.0%) vs baseline: +0.8% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.844µs (SLO: <10.000µs 📉 -71.6%) vs baseline: +0.9% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.4% ✅ title_aspectTime: ✅ 18.330µs (SLO: <20.000µs -8.3%) vs baseline: +0.1% Memory: ✅ 42.998MB (SLO: <43.000MB 🟡 ~same) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 2.691µs (SLO: <10.000µs 📉 -73.1%) vs baseline: -0.7% Memory: ✅ 43.116MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.4% ✅ translate_aspectTime: ✅ 20.490µs (SLO: <30.000µs 📉 -31.7%) vs baseline: -0.6% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 4.350µs (SLO: <10.000µs 📉 -56.5%) vs baseline: +0.3% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 17.956µs (SLO: <30.000µs 📉 -40.1%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 2.471µs (SLO: <10.000µs 📉 -75.3%) vs baseline: +1.0% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.195µs (SLO: <10.000µs 📉 -48.1%) vs baseline: 📈 +22.5% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 4.343µs (SLO: <10.000µs 📉 -56.6%) vs baseline: +0.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.256µs (SLO: <10.000µs 📉 -37.4%) vs baseline: +0.3% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 6.294µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.3% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.554µs (SLO: <10.000µs 📉 -64.5%) vs baseline: -0.9% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 3.647µs (SLO: <10.000µs 📉 -63.5%) vs baseline: ~same Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.6% ✅ ospathsplit_aspectTime: ✅ 4.908µs (SLO: <10.000µs 📉 -50.9%) vs baseline: +0.3% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 5.007µs (SLO: <10.000µs 📉 -49.9%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.725µs (SLO: <10.000µs 📉 -62.7%) vs baseline: -1.1% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.746µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -1.6% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.608µs (SLO: <10.000µs 📉 -53.9%) vs baseline: ~same Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 4.624µs (SLO: <10.000µs 📉 -53.8%) vs baseline: -0.3% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.352µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +13.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 198.222µs (SLO: <220.000µs -9.9%) vs baseline: -0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.316µs (SLO: <20.000µs 📉 -83.4%) vs baseline: -0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.628µs (SLO: <230.000µs -6.7%) vs baseline: +0.2% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.199µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.169µs (SLO: <150.000µs -9.2%) vs baseline: -0.7% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.088µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -1.1% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ 1-rate-metrics-100-timesTime: ✅ 212.642µs (SLO: <250.000µs 📉 -14.9%) vs baseline: -0.8% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.069ms (SLO: <22.000ms -8.8%) vs baseline: +1.1% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.249ms (SLO: <2.550ms 📉 -11.8%) vs baseline: +1.2% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.399ms (SLO: <1.550ms -9.8%) vs baseline: -0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ 100-rate-metrics-100-timesTime: ✅ 2.190ms (SLO: <2.550ms 📉 -14.1%) vs baseline: +0.5% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.514µs (SLO: <20.000µs 📉 -77.4%) vs baseline: -0.3% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.677µs (SLO: <250.000µs 📉 -30.5%) vs baseline: +0.2% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.166ms (SLO: <2.500ms 📉 -13.4%) vs baseline: ~same Memory: ✅ 36.058MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question about artifacts, otherwise lgtm
Description
This change migrates the "bootstrap import analysis" job from github actions to gitlab in the interest of reducing dependence on github actions. It uses the PR commenting service to replace a PR commenter github action.
Testing
The comment on this pull request was generated by the updated job.